Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support for configuring route-prefix #158

Open
prein opened this issue Apr 8, 2024 · 2 comments · May be fixed by #178
Open

Support for configuring route-prefix #158

prein opened this issue Apr 8, 2024 · 2 comments · May be fixed by #178

Comments

@prein
Copy link

prein commented Apr 8, 2024

Hi, for Pyrra to work behind proxy I set

pyrra:
  extraApiArgs:
    - --route-prefix=/pyrra

This however doesn't affect the path in service monitor which now becomes /pyrra/metrics and I have to vendor servicemonitor.yaml template.

A new value to control route prefix used in service monitor template and api args (and maybe more places that I didn't discover yet) would be helpful. Maybe .Values.routePrefix for a name?
@rlex
Copy link
Owner

rlex commented Apr 23, 2024

Another option might be extending serviceMonitor to support path variable. Should work too?

@prein
Copy link
Author

prein commented Jul 1, 2024

Another option might be extending serviceMonitor to support path variable. Should work too?

That's half of what is needed to satisfy my request, I assume. One part is that .Values.routePrefix or whatever the name is passed as --route-prefix to the app and the other part is service monitor updated accordingly. It can be controlled with another, as I guess, you suggest.

@fstr fstr linked a pull request Jan 4, 2025 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: add support for route-prefix fstr/helm-charts
2 participants
@rlex @prein