Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Why pass 'env' when recording eval video while passing 'obs' when recording train video? #20

Open
jsrimr opened this issue Apr 19, 2022 · 0 comments

Comments

@jsrimr
Copy link

jsrimr commented Apr 19, 2022

When I run
python pretrain.py agent=icm domain=walker save_train_video=true,
I encounter an error

  File "/root/url_benchmark/video.py", line 83, in record
    frame = cv2.resize(obs[-3:].transpose(1, 2, 0),

But recording evaluation video is okay.
Then I found that we call .record method differently between training and evaluating.

When we record eval video,

self.video_recorder.record(self.eval_env)

we pass 'env'.

When we record train video,

self.train_video_recorder.record(time_step.observation)

we pass observation.

Is this intended?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant