-
Notifications
You must be signed in to change notification settings - Fork 51
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
suggestion: move examples.demo_opts.get_device() into core #178
Comments
Sounds good! |
Would be good, yes please. Something like |
Cool. Thanks for guidance on the preferred naming. I'll give the docs a try as well. |
ping @BeauSlim |
Sorry for leaving this hanging. My laptop died and I could no longer code all comfy on my couch. I have a shiny new M1 Air now, this is still on my list and I should have some time soon. |
I've been messing around with a library I'm writing and trying it with numerous displays, including an ssd1306, an ili9341 and an st7789 in addition to the pygame emulator. A config file (same file name, different contents) helps when testing on different displays, so I have used examples' get_device() as a start.
While it isn't difficult to do
It occurs to me that something like device=conf2dev(dev_conf='device.conf') might be useful for users in general and really should be built into luma.core. Probably just the file-based config not the command line stuff, since that might be messy.
Or maybe the use of config files should just be documented better?
Either way I'm happy to work it up as a pull request.
The text was updated successfully, but these errors were encountered: