Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Rewrite tetraplot using high level functions #119

Closed
wants to merge 1 commit into from

Conversation

Bisaloo
Copy link
Collaborator

@Bisaloo Bisaloo commented Aug 8, 2018

Use high level plot3D functions to simplify the code and add a feature
to plot 2D projections of the 3D plot.

Fix #118

TODO:

  • Reimplement all arguments
  • Fix margins issue at some angles
  • Add tests
  • Update changelog
  • Update seealso: persp/scatter3D, plot.colspace, legendtetra, axistetra

@Bisaloo
Copy link
Collaborator Author

Bisaloo commented Oct 18, 2018

Here's where I am at the moment. The main issue is that the projections rotate with the rest of the plot when we want them to also be at the same place.

rplot02
rplot

@Bisaloo Bisaloo force-pushed the tetra_marginal branch 2 times, most recently from cd5dfa7 to 41d3c67 Compare October 18, 2018 15:56
Use high level plot3D functions to simplify the code and add a feature
to plot 2D projections of the 3D plot
@Bisaloo
Copy link
Collaborator Author

Bisaloo commented Jan 2, 2021

When I started this, I didn't realise the current implementation is able to display vertices in a different way depending on whether they are on the front or on the back. I'm not sure I would be able to emulate this with the simpler functions. Closing this PR since I don't think I'll work on this anymore. As usual, the code is always available here should we ever need it.

@Bisaloo Bisaloo closed this Jan 2, 2021
@Bisaloo Bisaloo deleted the tetra_marginal branch January 2, 2021 15:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add 2D marginal projections to 3D plots
1 participant