Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release notes link in About does not work on 45.1 #225

Open
Randrianasulu opened this issue Oct 30, 2024 · 4 comments
Open

Release notes link in About does not work on 45.1 #225

Randrianasulu opened this issue Oct 30, 2024 · 4 comments
Labels
hack A workaround has been found, but not a clean solution.

Comments

@Randrianasulu
Copy link

used version 44 for downloading 45.1 (via aseets link on github). It worked in general, but for some reason I see no reaction for "Release notes" link especially in "About" window?

macosx 10.6.8 via qemu (so no hw 3d).

@rmottola
Copy link
Owner

Hmm... it is a minor detail. It doesn't work under linux either, so it is not mac64 specific.

But looking at the code and preferences, I wonder if it ever worked?

@rmottola rmottola changed the title Release notes link in About does not work on 45.1 for mac64? Release notes link in About does not work on 45.1 Nov 15, 2024
@Randrianasulu
Copy link
Author

But looking at the code and preferences, I wonder if it ever worked?

I used it to open page on 44, and upgraded from there ....

@rmottola
Copy link
Owner

Interesting... I see no changes, it is an embedded link in preferences which is never set, I actually wonder how it could work!

@rmottola
Copy link
Owner

rmottola commented Dec 9, 2024

I think I fixed with a "hack" with this commit: 61203ab

However this value should come branding: https://github.com/rmottola/Arctic-Fox/blob/master/browser/branding/arcticfox/pref/firefox-branding.js
Apparently it is not happening!

@rmottola rmottola added the hack A workaround has been found, but not a clean solution. label Jan 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hack A workaround has been found, but not a clean solution.
Projects
None yet
Development

No branches or pull requests

2 participants