Description
- author(s): Yuri
- contact: @Yuripetusko
- RIP type: upgrade
RIP Summary
The new owner of the collection should fire an ACCEPT
command after it was passed to him through CHANGEISSUER
RIP Details
In order to prevent phishing attempts due to the fact that CHANGEISSUER only passes collection to the new owner and not NFTs, a new owner should ACCEPT incoming collection for issuer change to apply.
Original issuer retains all rights until the new issuer accepts it. The new issuer can only ACCEPT the incoming collection and nothing else
Examples
In the extrinsic version of RMRK standard, this can look like
RMRK::ACCEPTCOLLECTION::1.0.0::${collection_id}
Open Questions
Need to check a dump if someone did CHANGEISSUER multiple times on the same collection, as it should have failed because it wasn't accepted after the first time.
Prior work (optional)
?
Impact
In RMRK1 we need to make sure this doesn't affect any of existing collections. But since there's nothing that an issuer can do with his collection except for CHANGEISSUER again this shouldn't be a problem.
So the only thing that we need to check if someone did CHANGEISSUER multiple times on the same collection, as it should have failed because it wasn't accepted after the first time.
We also need to sync with Kodadot (@vikiival, @yangwao) and any indexer services like SubQuery and SubSquid
Thanks to @mmvds for hilighting this case