Skip to content
This repository has been archived by the owner on Oct 14, 2020. It is now read-only.

Support for web platform #9

Open
piranna opened this issue Mar 13, 2019 · 2 comments
Open

Support for web platform #9

piranna opened this issue Mar 13, 2019 · 2 comments
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@piranna
Copy link

piranna commented Mar 13, 2019

Add support for react-native-web. I have a working implementation at https://github.com/piranna/react-native-web-statusbar. Should it be used as a dependency, or should I add the code directly to this repo?

@dmtrKovalenko
Copy link
Collaborator

Hi @piranna. How it's done for other packages? I am not aware of react-native-web code in this repo. But I am for consistency with other packages

@dmtrKovalenko dmtrKovalenko added enhancement New feature or request good first issue Good for newcomers labels Mar 14, 2019
@piranna
Copy link
Author

piranna commented Mar 14, 2019

Hi @piranna. How it's done for other packages? I am not aware of react-native-web code in this repo. But I am for consistency with other packages

There's a mixture of react-native-web-* packages as a replic of their counterpart react-native-* ones, like the case of react-native-webrtc and react-native-web-webrtc, and the inclusion of a web folder or usage of *.web.js files inside the main repo. This last option is getting more popular lately since they are starting to surface more platforms, for example react-native-document-picker already support react-native-windows, and I've already do a pull-request to add support for web platform there.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

2 participants