Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Numbers are not visible on some spin button items.(Windows11 Widget Theme and HiDPI?) #81

Open
nanitaro opened this issue Apr 26, 2024 · 4 comments

Comments

@nanitaro
Copy link

Hello.

Windows 11 (Surface 7 Pro , Custom scaling set to 200%)
Qsynth 0.9.90

In the above environment, numbers are not visible on some spin button items.
For example, MIDI Channels in the Setup screen, MIDI tab.
setup-midi-0 9 90
Polyphony in the Audio tab.
setup-audio 0 9 90

In 0.9.13, they were displayed without any problem.
setup-midi-0 9 13
setup-audio 0 9 13

@pedrolcl
Copy link
Contributor

I cannot reproduce this issue in Windows 10, with my screen (125% scaling).

In my opinion, this should be fixed in Qsynth, with a more flexible layout setting for spin boxes.

But anyway, here is a workaround for you:

  • Press the "Options" button in the main window.
  • Switch to the "Display" tab
  • in the combo box "Widget style theme", try some other option. My suggestion is "Fusion"

imagen

@nanitaro
Copy link
Author

Thank you.
I set the Widget style theme to something other than Default and Windows11 and that solved the problem.
setup-midi-0 9 90-fusion

I understand that the problem is with the Windows11 theme.
I will leave it open until the problem is resolved.

@nanitaro nanitaro changed the title Numbers are not visible on some spin button items. Numbers are not visible on some spin button items.(Windows11 Widget Theme and HiDPI?) Apr 26, 2024
@pedrolcl
Copy link
Contributor

I understand that the problem is with the Windows11 theme.

Yes. The Windows11 style is new in Qt 6.7 (recently released), and it has been bundled in Qsynth 0.9.90. The spin boxes are more "touch friendly" than before, but they also demand more screen space. This is only a windows issue for now, but having style plugins in Qt means that we may have this problem as well in the future in a new KDE or GTK style.

@rncbc : what do you think about changing the spin boxes in qsynthSetupForm.ui , sizePolicy - horizontal, from Minimum to MinimumExpanding?

Example:

     <widget class="QSpinBox" name="MidiChannelsSpinBox">
         <property name="sizePolicy">
          <sizepolicy hsizetype="MinimumExpanding"
        [...]

@nanitaro
Copy link
Author

nanitaro commented Aug 7, 2024

Sorry for the delay in responding.
The spin box refurbishment seems to be mostly OK.
(Confirmed with 1.0.0).

However, I had one point of concern.
It is the MIDI device select box.
setup

If there is a long MIDI device name, the number and the beginning of the name seem to be omitted.
I think it is inevitable to omit MIDI device names, but I think it would be easier to understand if the end of the name is omitted rather than the beginning.

If you do not see a need to fix this, close this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants