Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add the ability to send messages to a private channel and update help text to use channel name #51

Merged
merged 2 commits into from
Aug 29, 2023

Conversation

ACyphus
Copy link
Contributor

@ACyphus ACyphus commented Aug 28, 2023

This pull request does two things:

  1. Adds the ability to send messages to a private channel and thus close Unable to send to private channel #50
  2. Changes the help text to suggest using the Slack channel name instead of the channel id. I've found this to more reliably work in my usage and testing.

@rneatherway if you want to keep the channel id in the help text, we can drop the commit that changes it ✌️

ACyphus and others added 2 commits August 28, 2023 10:06
This commit adds `private_channel` to the types of channel that can
have messages sent to it.

Co-authored-by: Robin Neatherway <[email protected]>
In my experience, using the channel name is more reliable than using
the channel id. This commit changes the help text to recommend
using the channel name
@rneatherway
Copy link
Owner

Looks good, thanks!

@rneatherway rneatherway merged commit 6390aac into rneatherway:main Aug 29, 2023
2 checks passed
@rneatherway
Copy link
Owner

I've cut a release so you should be able to update to that now.

@ACyphus ACyphus deleted the add-private-channel-sending branch August 29, 2023 13:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unable to send to private channel
2 participants