-
-
Notifications
You must be signed in to change notification settings - Fork 888
RN 0.77 support #3753
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
I've opened a draft PR about supporting but need some input from the maintainers |
try this patch, works for me |
thanks, working for me.. |
i'm still getting the error after applying the patch but it is at using same exact version:
Tried
Is there anything that needs to be done apart from the patch? |
getting the same issue @1453alabanda @ulucantugberk may i know your android setup |
I tried and it didn't work, can you send me more details of your environment on Android? things like, Kotlinversion, compileSdkVersion, etc |
Install the lib patch-package, download the package below (is different from the patches above) this works
|
Patch package failed for me It's the first time I'm working with patch package, am I doing something wrong?
On my dependencies I have |
this one worked tough |
With patch file: e: file:///C:/..../node_modules/@rnmapbox/maps/android/src/main/java/com/rnmapbox/rnmbx/components/annotation/RNMBXMarkerViewManager.kt:28:52 Argument type mismatch: actual type is 'com.rnmapbox.rnmbx.components.annotation.RNMBXMarkerViewManager', but 'U!' was expected.
e: file:///C:/..../node_modules/@rnmapbox/maps/android/src/main/java/com/rnmapbox/rnmbx/components/annotation/RNMBXPointAnnotationManager.kt:24:57 Argument type mismatch: actual type is 'com.rnmapbox.rnmbx.components.annotation.RNMBXPointAnnotationManager', but 'U!' was expected.
e: file:///C:/..../node_modules/@rnmapbox/maps/android/src/main/java/com/rnmapbox/rnmbx/components/mapview/RNMBXMapViewManager.kt:60:63 Type argument is not within its bounds: should be subtype of 'it(BaseViewManagerInterface & com.facebook.react.viewmanagers.RNMBXMapViewManagerInterface<com.rnmapbox.rnmbx.components.mapview.RNMBXMapView!>)!'.
e: file:///C:/..../node_modules/@rnmapbox/maps/android/src/main/java/com/rnmapbox/rnmbx/components/mapview/RNMBXMapViewManager.kt:60:84 Argument type mismatch: actual type is 'com.rnmapbox.rnmbx.components.mapview.RNMBXMapViewManager', but 'U!' was expected.
e: file:///C:/..../node_modules/@rnmapbox/maps/android/src/main/java/com/rnmapbox/rnmbx/components/styles/atmosphere/RNMBXAtmosphereManager.kt:16:52 Argument type mismatch: actual type is 'com.rnmapbox.rnmbx.components.styles.atmosphere.RNMBXAtmosphereManager', but 'U!' was expected
``` |
Try to strict the versin to |
That has nothing to do with Kotlin errors. Kotlin isn't affected by gradle or yarn cache. What Kotlin version are you using? |
Hello I am facing the same issue as you @talaikis after applying the first suggested patch. I am currently using : Android gradle plugin: 8.7.2
Gradle: 8.10.2
React-Native: 0.77
Kotlin 2.0.21 (the one suggested by the upgrade helper)
minSdkVersion: 24
compileSdkVersion: 35
targetSdkVersion: 34
ndkVersion : "27.1.12297006"
agp_version : '8.8.1' But from what I saw in the official Android docs, I might be using an outdated AGP version, I'll try to bump it and I'll come back to you to confirm if after that the patch worked EDIT: from what I've tested, even if I upgrade to latest AGP issue, I'm still facing the issue after running the first patch EDIT 2: the patch suggested by @brunoscardoso works perfectly, thank you very much ! 💯 I saw there is a PR for the support of react-native 0.77, let's hope it get merged soon 👍 |
@rnmapbox-maps-npm-10.1.37-06aa7f1b50.patch Here's our patch compatible with version Note that we use yarn berry (v4) so the patch format is a bit different if you use
to:
The patch was implemented & tested with an Expo project using 0.77.1:
|
@iffa I can confirm this works on RN 0.78 as well (plain expo-less RN app) with patch-package. Attached the used patch file. filename: Thx! Much appreciated! |
The version 10.1.37 with the patch applied crashes on Android in release mode on a real device. It works fine in debug mode and also in the emulator, but as soon as the app runs on a real device in release mode, it crashes immediately on launch. The logs I have : 03-07 17:05:31.792 8186 8219 E cc.nearyou.app: Invalid ID 0x00000000. Has anyone else experienced this issue? Is there any fix or workaround available? Thanks! |
@PierreMartin - I have ONE device in production that's hitting this crash - at least I think it's the same thing, all I have is the stack trace from the google play console. All of the rest of them are working fine, including my local test devices. The prod device that's breaking is a Samsumg a13x running android 13 (sdk 33). What device/api are you seeing it on? It'd be nice to narrow down what the incompatibility is so it could at least be reproduced in a simulator. |
Any updates on this? SLowly getting more and more behind on react native versions... |
The patch version for 10.1.38.
|
I can confirm this patch also works on: "@rnmapbox/maps": "10.1.38", kotlinVersion = "2.0.21" Thanks! Hope this gets merged soon. |
How to install the patch |
or
in package.json:
then put the patch file in a "patches" folder. (patches/@rnmapbox+maps+10.1.38.patch) patch will be applied when you do an npm/yarn install hope this get's merged soon. |
Patch works for Android. What do you think about iOS? I got this error for iOS build: › Packaging expo-json-utils Pods/EXJSONUtils » libEXJSONUtils.a ❌ (/Users/expo/workingdir/build/packages/app/ios/Pods/MapboxMaps/Sources/MapboxMaps/Annotations/ViewAnnotationManager.swift:79:19) 77 | @available(*, deprecated, message: "Use ViewAnnotation")
|
I have the same issue on version 10.1.36, but because of this crash , I can't use the version 10.1.38. Which patch should i use for the version 10.1.36? (10.1.37 version doesn't work either for me) |
I am using this only for Android, I have not tested it for IOS. |
Thank you 🙏🏼 |
it works, thanks 🙏 |
Deprecated Gradle features were used in this build, making it incompatible with Gradle 9.0. You can use '--warning-mode all' to show the individual deprecation warnings and determine if they come from your own scripts or plugins. For more on this, please refer to https://docs.gradle.org/8.10.2/userguide/command_line_interface.html#sec:command_line_warnings in the Gradle documentation. |
@bfd-paul-vicknair Hi, I'm facing the same issue on Samsung A13 running Android 14 (SDK 34). Have you found any solution or workaround for this problem yet? |
Hi I am still facing the same issue with the config:
|
With the patch 10.1.37 + "@rnmapbox/maps": "^10.1.37" and by following the Troubleshooting section in the installation guide, everything works well for me. |
Any news on a new mapbox version that doesn't need the patch? |
Issue is still there |
Patch worked for me |
Thanks!!! This worked for me too!! I'll summarize the steps again for clarity:
This process helped me fix issues with At first, I thought it was still related to
You need to upgrade to a version of
If this doesn't work, make your file path shorter just in case. The reason for this is that the NDK contains a limited number of path characters. In one of my projects, this was the cause of the problem. |
What versions do you have installed and which patch are you using? |
Maybe install react-native 0.79.0. I have the same versions (except react native), and same patch, and it works |
@rnmapbox+maps+10.1.38.patch This patch works well in 10.1.36 also. Rename this patch to 10.1.36, use that with v10.1.36 and it works |
Environment
Steps to reproduce
Errors
The text was updated successfully, but these errors were encountered: