Refactor pgp_key_search_t #2187
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ni4
force-pushed
the
ni4-refactor-pgp_key_search_t
branch
from
3e90da9 to
8a6e9b6
Compare
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #2187 +/- ##
==========================================
+ Coverage 77.26% 77.29% +0.02%
==========================================
Files 194 194
Lines 37751 37692 -59
==========================================
- Hits 29170 29135 -35
+ Misses 8581 8557 -24 ☔ View full report in Codecov by Sentry. |
ni4
force-pushed
the
ni4-refactor-pgp_key_search_t
branch
from
8a6e9b6 to
9df4427
Compare
maxirmx
requested changes
Feb 1, 2024
ni4
force-pushed
the
ni4-refactor-pgp_key_search_t
branch
from
2862a8a to
625ad86
Compare
Is it actually faster now? :P |
|
There is some conflict, probably caused by the recent merged PR... |
I mean faster transition to C++ from all the anonymous unions, char * and suchlike internal stuff :) I'll rebase and fix errors and ping you back for review, thanks! |
ni4
force-pushed
the
ni4-refactor-pgp_key_search_t
branch
3 times, most recently
from
1161ae9 to
a388301
Compare
ni4
force-pushed
the
ni4-refactor-pgp_key_search_t
branch
from
a388301 to
f58c69a
Compare
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
ni4
force-pushed
the
ni4-refactor-pgp_key_search_t
branch
4 times, most recently
from
55a2b14 to
683ade3
Compare
ni4
force-pushed
the
ni4-refactor-pgp_key_search_t
branch
3 times, most recently
from
07ae57a to
8c433ee
Compare
ni4
force-pushed
the
ni4-refactor-pgp_key_search_t
branch
from
8c433ee to
bab4033
Compare
…e issue with hex decoding.
ni4
force-pushed
the
ni4-refactor-pgp_key_search_t
branch
from
bab4033 to
e40c4ff
Compare
|
@ronaldtse @antonsviridenko ping for review. Spend a lot of time on debugging on some test failure but separated it to the issue #2192 as too much time was spent on it. |
ronaldtse
approved these changes
Mar 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Another one on the C++-transition way.Thought it would be faster...