Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[💡 FEATURE REQUEST]: Add debug mode indication to plugin start log #2018

Open
Kaspiman opened this issue Oct 5, 2024 · 1 comment
Open
Assignees
Labels
C-feature-accepted Category: Feature discussed and accepted help-needed-easy Call for participation: Experience needed to fix: Easy / not much

Comments

@Kaspiman
Copy link

Kaspiman commented Oct 5, 2024

Plugin

Server

I have an idea!

Hello! I often have to switch between debug mode and back.

It is not always clear what mode the server is in. What if we add this information for each plugin?

For example pool.debug or debug:

{"level":"debug","ts":1728138499360931181,"logger":"http","msg":"http server was started", "pool.debug": "true", "address":"0.0.0.0:8080"}
@Kaspiman Kaspiman added the C-feature-request Category: feature requested, but need to be discussed label Oct 5, 2024
@rustatian
Copy link
Member

rustatian commented Oct 5, 2024

Hey @Kaspiman 👋
Actually, a good idea. To do that, we need to add a some kind of Mode() Mode method to the static pool with 2 modes (atm), Debug and...hm, Production... Need to think about the non-debug mode name.

And then use this mode in plugins to check the pool state and print this info (once) in the logs under I think info log level.

@rustatian rustatian added help-needed-easy Call for participation: Experience needed to fix: Easy / not much C-feature-accepted Category: Feature discussed and accepted and removed C-feature-request Category: feature requested, but need to be discussed labels Oct 5, 2024
@rustatian rustatian moved this to 📋 Backlog in Jira 😄 Oct 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-feature-accepted Category: Feature discussed and accepted help-needed-easy Call for participation: Experience needed to fix: Easy / not much
Projects
Status: 📋 Backlog
Development

No branches or pull requests

2 participants