Skip to content

Hashing for ReachSetGenerator doesn't use actual passthrough_args #11

Open
@Orbital-Web

Description

@Orbital-Web

rtd.planner.reachsets.ReachSetGenerator, line 108-114

for hash_arg = 1:length(passthrough_args)
    try
        hash = hash + strjoin(string(hash_arg));
    catch
        % Ignore if not possible
    end
end

Currently, the generated hash is the uuid + '1234...n', where n is the length of the passthrough_args (or shorter if the try fails).

Thus, the generated hash when using the same robotState with passthrough_args={"abc", 1, "def", true} and passthrough_args={"a", 5, "z", 4} for example, is equivalent as both passthrough_args have 4 entries.

I believe the intended effect is to append the name/value inside passthrough_args to the hash. In the case with the first example, the hash would be the uuid + 'abc1deftrue'. Thus, line 110 should be modified to

hash = hash + strjoin(string(passthrough_args{hash_arg}));

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugSomething isn't working

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions