Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hashing for ReachSetGenerator doesn't use actual passthrough_args #11

Open
Orbital-Web opened this issue Jul 1, 2023 · 0 comments
Open
Labels
bug Something isn't working

Comments

@Orbital-Web
Copy link
Collaborator

rtd.planner.reachsets.ReachSetGenerator, line 108-114

for hash_arg = 1:length(passthrough_args)
    try
        hash = hash + strjoin(string(hash_arg));
    catch
        % Ignore if not possible
    end
end

Currently, the generated hash is the uuid + '1234...n', where n is the length of the passthrough_args (or shorter if the try fails).

Thus, the generated hash when using the same robotState with passthrough_args={"abc", 1, "def", true} and passthrough_args={"a", 5, "z", 4} for example, is equivalent as both passthrough_args have 4 entries.

I believe the intended effect is to append the name/value inside passthrough_args to the hash. In the case with the first example, the hash would be the uuid + 'abc1deftrue'. Thus, line 110 should be modified to

hash = hash + strjoin(string(passthrough_args{hash_arg}));

@Orbital-Web Orbital-Web added invalid This doesn't seem right bug Something isn't working and removed invalid This doesn't seem right labels Jul 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant