Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Terminal .write() stops working after component is first unmounted #13

Open
xobs opened this issue Jul 26, 2022 · 0 comments
Open

Terminal .write() stops working after component is first unmounted #13

xobs opened this issue Jul 26, 2022 · 0 comments

Comments

@xobs
Copy link

xobs commented Jul 26, 2022

Description

When a component is unmounted, XTerm.tsx calls this.terminal.dispose(). As part of this call, xterm.js sets _isDisposed = true and destroys its .write() call.

Thereafter, all calls to .write() will silently fail.

I have an issue open at xtermjs/xterm.js#3939 to address this, but I suspect this may be the wrong approach to take to unhook key handlers.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant