-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improvements #13
Comments
Hello @egilll, Your demo looks cool! Thanks for your offer. I welcome contributions that are focused and have good documentation / tests. I'd like the core layout code to remain accessible for educational purposes, which means being judicious about extra options/complexity added there. What I would suggest to do if you'd like to submit PRs is to start with one or two of the smaller / easier improvements from your list and make PRs specifically for those. |
The basic changes here are somewhat difficult to separate, I believe, unless the intention were to merge them all sequentially anyways. While it would be possible to e.g. only add support for Unicode's line breaking algorithm, I wouldn't view it as being useful enough to users by itself given that These changes mainly affect the helper functions and the API, while the core algorithm ( |
If there are structural changes it might not make sense to chunk up the changes exactly by feature, that's OK. The main point I'm making is that smaller, incremental changes are generally easier to understand and review. So if there is a way to do that, it increases the chances that I can actually integrate and release them. This is especially true given I've only got a limited amount of time in the week for side projects.
Perhaps these two changes to the core algorithm are a good place to start. These certainly sound like something that can be separated from the rest. |
Hi. Over at egilll/tex-linebreak2 I've added some features to this excellent project. There is a demo here.
Features:
There are still many edge cases that I haven't covered and need to write multiple test cases (many of these things, especially regarding HTML, are however quite difficult to test). The fork is still in a state of "work-in-progress".
Would you be interested in a pull request? In that case I would try to maintain backwards compatibility with the previous version. Would be interested in hearing your thoughts.
I am aware that this is a somewhat old project, so no problem at all if you do not wish to invest time into this at the moment.
The text was updated successfully, but these errors were encountered: