-
Notifications
You must be signed in to change notification settings - Fork 588
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
BenchmarkJsArrayQuickSort10000 doesn't finish when running all benchmarks #378
Comments
Trying the benchmark with smaller arrays seems to work, it just takes insanely long. Far longer than is normal for quick sort. |
Reduce the item count in JavaScript sort benchmarks to something more reasonable given the memory pressure they cause. Fixes #378
The cause of this is shear number of allocation requests due to the why lots of temporary structs that are created when running the JS sort code. When running this code with just 500 items it allocates 19GB. I have a some work in progress code which uses In the mean time I've reduced the count from 10k to 500 which results in a reasonable time to run. |
Reduce the item count in JavaScript sort benchmarks to something more reasonable given the memory pressure they cause. Fixes #378
Keeping this open to track progress on improving memory usage. |
Reduce the item count in JavaScript sort benchmarks to something more reasonable given the memory pressure they cause. Fixes robertkrimen#378
Attempting to run all benchmarks with
go test -bench .
in the root folder stops at BenchmarkJsArrayQuickSort10000, when the benchmark will run forever without finishing. Memory usage jumps up to 1.3GB and CPU usage to 100% on one core.The text was updated successfully, but these errors were encountered: