Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding PDO access permissions #260

Closed
wants to merge 1 commit into from
Closed

Adding PDO access permissions #260

wants to merge 1 commit into from

Conversation

StormOli
Copy link

Closes #259

@CANopenNode
Copy link
Contributor

CANopenNode commented Jun 29, 2021

I made quite a lot of code for the latest versions. But didn't touch tabs: "TX PDO Mapping", "RX PDO Mapping" and "Modules".

"Device Info" and "Object Dictionary" are renewed and additional PDO can be added there. This is more raw approach, but I can currently maintain only that.

As I understand, @robincornelius is quite busy and didn't switch to v4 yet, which introduced quite a lot of changes. And libedssharp is quite extensive.

I can include this PR into CANopenEditor, which is fork of libedssharp and is currently few commits ahead. If there are other fixes to "TX PDO Mapping", "RX PDO Mapping" or else, I would like to include them into CANopenEditor. (#258?)
What do you think?

@StormOli
Copy link
Author

Hi Janez,
I hadn't noticed the new CANopenEditor fork. Seems like a great idea!!!
I'll close this pull request and open another there instead

@StormOli StormOli closed this Jun 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Updating Tx PDO mapping changes access privileges incorrectly
2 participants