Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Linkify domain-only links (without scheme or www) #30

Open
theyuv opened this issue May 8, 2019 · 1 comment
Open

Linkify domain-only links (without scheme or www) #30

theyuv opened this issue May 8, 2019 · 1 comment

Comments

@theyuv
Copy link

theyuv commented May 8, 2019

Thanks for your library.

Would you consider adding a LinkType for just domains (eg: example.com)?

There are some cases where this is considered a link and needs to be detected/extracted (eg: Gmail and Twitter detect domains like these as links and turn them into an anchor tag).

Thanks again.

@theyuv theyuv changed the title Consider adding LinkType for 2 part domain Consider adding LinkType for domain May 8, 2019
@robinst
Copy link
Owner

robinst commented Jul 2, 2019

Hey! Yeah, extraction of plain domains would be handy. I think we'd need to be able to specify an "include list" of domains that should be detected, otherwise it tends to detect a lot of false positives. Or we'd ask the caller to do that themselves.

Anyway, I added a "help wanted" label and welcome pull requests for this.

@robinst robinst changed the title Consider adding LinkType for domain Linkify domain-only links (without scheme or www) Apr 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants