-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Simplify code coverage in CI builds #50
Comments
Yes. That looks cleaner, clearer, and much more efficient. |
BTW: set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} -fprofile-arcs -ftest-coverage") This also sets linker flags, while the following doesn't (and makes lcov/gcov crash with undefined reference errors, see this Travis job): add_compile_options(-fprofile-arcs -ftest-coverage) |
Also revert a broken add_compile_options() call for code coverage.
Perhaps not worth the trouble if we switch to Codecov at some point: #71. |
Not too sure, form a quick glance, Codecov looks different but not automatic: https://github.com/codecov/example-cpp11-cmake/blob/9c09479b7edfdc5e75f29a00e36a94394e688bdf/.travis.yml Edit: Seeing https://docs.codecov.io/docs, maybethe "upload" step can be automatic, but all the |
As part of our ongoing transition to GitHub Actions at #91, we decided to drop support for automated code coverage since we had not been using this tool anyway. In case it is deemed convenient to reinstate such support, see modern alternatives and complementary tools to Coveralls such as #71 and #68. Marking as wontfix and closing due to obsolescence. |
Our Travis lines for code coverage (via Coveralls) look like this (source):
Perhaps a bit too convoluted if we take a look at official docs:
Copy-paste from the latter:
More links (compiler flags et al.):
The text was updated successfully, but these errors were encountered: