YCM 0.10 upgrade path

[PeterBowman]

Currently in devel branch (release notes):

• Rejected (see YCM 0.10 upgrade path #78 (comment)). The FetchContent module from CMake 3.11 will be imported via cmake-next. We might want to fetch googletest on configure time (already moved from embedded copy to apt package or on-system installation), see Look for system-installed googletest for use in Travis builds, drop embedded copies #41 (comment).

• The ExternalProject module from CMake master was locally updated into cmake-next/proposed, allegedly most customizations had been removed. We use the CONFIGURE_SOURCE_DIR option, which does not exist anymore, in the Buildorocos_kdl.cmake script across superbuild projects. I suspect this may break once YCM 0.10 is merged into master. The CONFIGURE_SOURCE_DIR might need to be replaced with SOURCE_DIR, not sure though.

• Use GIT_SHALLOW TRUE option to ycm_ep_helper() here.

• Use GIT_PROGRESS TRUE option to ycm_ep_helper() in heavy repos (e.g. OpenRAVE and YARP).

• Make dox target (Make dox target via YCM goodies #79).

• The FIRST_TARGET option to install_basic_package_files() could be safely removed from downstream code (InstallBasicPackageFiles: FIRST_TARGET may be useless robotology/ycm-cmake-modules#215 + InstallBasicPackageFiles: don't require targets and deprecate NO_COMPATIBILITY_VARS robotology/ycm-cmake-modules#239) (as well as NO_COMPATIBILITY_VARS).

• Set up non-interactive builds (take two): DEVEL_MODE is ignored in NON_INTERACTIVE_BUILD for packages that have an hyphen in the name robotology/ycm-cmake-modules#225 + Add section for YCM/cmake common practices developer-manual#18 (comment) + Add section for YCM/cmake common practices developer-manual#18 (comment). We are going to remove git config --global user.xxx lines from every .travis.yml.

• Drop install-related lines in superbuild-repos (ref): YCMEPHelper: Add subproject install to main build robotology/ycm-cmake-modules#235 (experimental?).

• Update local YCM modules, e.g. IncludeUrl.

• Request YCM 0.10 or later via YCM_MINIMUM_VERSION: YCM bootstrap script does not honor YCM_TAG for on-system lookup #55 (comment).

[PeterBowman]

* I suspect this may break once YCM 0.10 is merged into master. The `CONFIGURE_SOURCE_DIR` might need to be replaced with `SOURCE_DIR`, not sure though.

It does break, indeed. The upstream CMake option should read SOURCE_SUBDIR. Reported at robotology/ycm-cmake-modules#210.

[PeterBowman]

It does break, indeed.

My bad, got fooled by the way CMake treats local and cached variables. See robotology/ycm-cmake-modules#210 (comment) for context.

[PeterBowman]

The ExternalProject module from CMake master was locally updated into cmake-next/proposed [...]

TODO: replace deprecated option (needs YCM 0.10) and apply workaround given at robotology/ycm-cmake-modules#212 (can/should? be done now).

[PeterBowman]

The ExternalProject module from CMake master was locally updated into cmake-next/proposed, allegedly most customizations had been removed. We use the CONFIGURE_SOURCE_DIR option

TODO: replace deprecated option (needs YCM 0.10) and apply workaround given at robotology/ycm#212 (can/should? be done now).

No hurry, our current code will work fine thanks to the upstream workaround. This bullet boils down to replacing the will-be-deprecated option to ycm_ep_helper().

[PeterBowman]

YCM v0.10 is out! https://github.com/robotology/ycm/releases/tag/v0.10.0

[PeterBowman]

YCM v0.10.1 was released today. We might have found another issue: robotology/ycm-cmake-modules#244.

[PeterBowman]

We might have found another issue: robotology/ycm#244.

Fixed in current YCM master branch, scheduled for v0.10.2. This has fixed our superbuild Travis jobs, too.

[PeterBowman]

The FetchContent module from CMake 3.11 will be imported via cmake-next. We might want to fetch googletest on configure time (already moved from embedded copy to apt package or on-system installation), see #41 (comment).

I can't think of a good solution, see #41 (comment). The FetchContent way is kinda close to YCM superbuilds, which I wanted to avoid. On the other hand, it gives total control of the googletest version requested, but we'd like to look for it on system first (the YCM-way) and fall back to the download step - this option involves a custom FindGTestSources script, again.

Nothing more to do here, closing.

[PeterBowman]

Drop install-related lines in superbuild-repos (ref): robotology/ycm#235 (experimental?).

Will be made relocatable, see robotology/ycm-cmake-modules#289.

[PeterBowman]

The GIT_SHALLOW and GIT_PROGRESS were actually ignored since ycm_ep_helper never forwarded them to ExternalProject_Add. Support has been recently added for a SHALLOW option (robotology/ycm-cmake-modules#440), I'm going to use this instead.

[traversaro]

@PeterBowman if you need more arguments to be forwarded to ExternalProject feel free to suggest them!