Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve BAT firmware for reliable battery charge for R1 #513

Closed
MSECode opened this issue Sep 17, 2024 · 1 comment
Closed

Improve BAT firmware for reliable battery charge for R1 #513

MSECode opened this issue Sep 17, 2024 · 1 comment
Assignees

Comments

@MSECode
Copy link
Contributor

MSECode commented Sep 17, 2024

This is a wrapper issue for https://github.com/icub-tech-iit/tickets/issues/3545

The aim is to adjust the limits used for evaluating the battery charge of R1 from the BAT.
A side note to be done is that the evaluated battery charge is not completely reliable since it is based on just the mean voltage and it is linear between its max and min.

The lower and upper bound have been defined as already done for ergoCub and as shown at this comment: #476 (comment)

I've used the same starting values (which are then differently weighted by the number of cells we have in series) since the cell used is the same, i.e. Panasonic NCR18650

@MSECode
Copy link
Contributor Author

MSECode commented Sep 17, 2024

As requested by the ticket listed and following the decision previously made and described at the linked comment, we can open the PR on firmware and firmware-build. Basically, in order to provide a more reliable evaluation of the battery charge for R1 coming from the BAT we adjust the lower threshold.

PR are linked here:

Let me know if the changes are fine, so I can move the PRs in ready. I'll keep them in draft for now even if the changes is minimal.

cc: @maggia80 @valegagge

@MSECode MSECode closed this as completed Sep 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant