-
Notifications
You must be signed in to change notification settings - Fork 118
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Protect master branch and use only pull request on it #9
Comments
I totally agree. |
Considering that right now only the three of us have push access and that lately I am pushing directly to |
No 😉, it is also for me. Because I don't want to change the code under your feet 😄 |
It may be also a good eventually to setup a changelog and tag releases. I do not think we have guidelines for all the workflow, but it would make sense to write them. |
It should be also nice to use |
I think @diegoferigo is an expert on this. Personally I never liked generating the doxygen docs from travis because I was never been able to deal with the amount of configuration necessary. I have a few alternatives for that, but I think it would take a few weeks to set them up. |
@GiulioRomualdi It is fairly easy to setup travis for pushing using tokens. Have a look here for a reference (this also deploys a mkdocs-based website, mind only doxygen sections). This works fine if you have a CMake target that generates the documentation as robotology/how-to-export-cpp-library. Otherwise you can follow the guide you linked which contains a script, and replacing the ssh keys authentication (which is overcomplicated) with token authentication. |
Currently, this repo is used only by @S-Dafarra and @GiulioRomualdi but, in the short time, it will be added inside the
robotology-superbuild
robotology/robotology-superbuild#55 so others users may be interested to use it and edit it.In my opinion, we should force using pull requests, this can be ensured enabling GitHub branch restrictions for the branch
master
https://help.github.com/articles/enabling-branch-restrictions/Using pull requests we can take the trace of the development of the code and, moreover, they are useful to inform others what we are trying to do.
In order to make this as clean as possible an
issue_template.md
and apull_request_template.md
files should be added.Sorry if I am too punctilious 😳
what do you think @traversaro, @S-Dafarra ?
The text was updated successfully, but these errors were encountered: