Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add the possibility to store the robot name inside the telemetry #160

Closed
GiulioRomualdi opened this issue Mar 23, 2022 · 5 comments · Fixed by #162
Closed

Add the possibility to store the robot name inside the telemetry #160

GiulioRomualdi opened this issue Mar 23, 2022 · 5 comments · Fixed by #162
Assignees
Labels
enhancement New feature or request

Comments

@GiulioRomualdi
Copy link
Member

It would be nice to add a string containing the name of the robot.
The idea is to add it at the same level of description_list a possible name could be robot_name.

What do you think @Nicogene @S-Dafarra @traversaro @AlexAntn

@Nicogene
Copy link
Member

I think it can be added without problems!

@S-Dafarra
Copy link
Collaborator

I think it is ok to add it. Do you envision cases where different signals have different robot_names?

On a more abstract level, I think this issue is a close relative to #156

In general, I think that these issues could be solved in the long-term by adding some sort of custom configuration struct (like in #154)

@traversaro
Copy link
Member

traversaro commented Mar 24, 2022

Probably we can be explicit and call it yarp_robot_name ? Just to avoid problems if in the future we want to encode other robot-related information (such as directly URI of the URDF model using the ROS-URI package://iCub/robots/iCubGenova09/model.urdf, see robotology/icub-models#90) and we may get confused.

@GiulioRomualdi
Copy link
Member Author

I will go for yarp_robot_name!

@GiulioRomualdi
Copy link
Member Author

I think it is ok to add it. Do you envision cases where different signals have different robot_names?

For the time being, I would just add a string that should contain the yarp_robot_name of the machine where the yarp_telemetry is used.
Then I agree we should add a struct containing several info. i.e. the robot name, the text logs (the one displayed in YarpLog for each IP)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants