Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable tags not working for ros2 #663

Closed
SimoneMic opened this issue Jul 2, 2024 · 11 comments
Closed

Enable tags not working for ros2 #663

SimoneMic opened this issue Jul 2, 2024 · 11 comments
Assignees

Comments

@SimoneMic
Copy link
Contributor

SimoneMic commented Jul 2, 2024

Hello,
I have tried the command for launching the YRI with ros2 enabled, as listed in this issue #641

However the format is not recognised:

yarprobotinterface --config ergocub.xml --enable_tags (enable_ros2) 
-bash: syntax error near unexpected token `('

I have also tried removing the brackets, the robot starts, but Ros is not enabled.
Also by removing the --config part. Same result.

@traversaro
Copy link
Member

Can you try:

yarprobotinterface --config ergocub.xml --enable_tags "(enable_ros2)"

Not sure why I did not experienced this problem, perhaps I tested on Windows.

@pattacini
Copy link
Member

Any feedback @SimoneMic?

@SimoneMic
Copy link
Contributor Author

I haven't used the robot today, when I'll have my slot I will test it

@pattacini
Copy link
Member

Thanks!

@pattacini pattacini self-assigned this Jul 4, 2024
@GiulioRomualdi
Copy link
Member

yarprobotinterface --config ergocub.xml --disable_tags \(disable_right_arm\) 

works

@pattacini
Copy link
Member

pattacini commented Jul 5, 2024

Uhm, the format with the escape char \ doesn't seem very clear in the first place, unless it's reported in the documentation. If not, it should be pointed out in YARP, somehow cc @randaz81.

Out of curiosity, does it mean that "(disable_right_arm)" doesn't work?

@SimoneMic
Copy link
Contributor Author

SimoneMic commented Jul 5, 2024

With the "()" it works, at least with enable_ros2.
The documentation should be changed, I think

@randaz81
Copy link
Member

randaz81 commented Jul 5, 2024

I never heard about the use of '', I think it works by chance (undocumented and to be avoided.)
Instead if i remeber correctly you should always use " to encapsulate a ( ) block, independently if it contains multiple elements or just one, like in your case.

@pattacini
Copy link
Member

Yeah, indeed, the standard ought to be "(...)".
I remember now that I used it in the past for the find-superquadric module:

I think we can close it.
Feel free to open it up again if you deem it necessary.

@traversaro
Copy link
Member

The documentation should be changed, I think

Which documentation?

@SimoneMic
Copy link
Contributor Author

#641 which has already been updated

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants