-
Notifications
You must be signed in to change notification settings - Fork 70
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add alljoints-inertials_wrapper/remapper to expose IMU orientation measurements #632
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pattacini
approved these changes
Mar 22, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks heaps @martinaxgloria 👍🏻
The CI passed 👍🏻 |
traversaro
reviewed
Mar 22, 2024
ergoCubSN000/wrappers/inertials/alljoints-inertials_remapper.xml
Outdated
Show resolved
Hide resolved
traversaro
reviewed
Mar 22, 2024
ergoCubSN001/wrappers/inertials/alljoints-inertials_wrapper.xml
Outdated
Show resolved
Hide resolved
traversaro
reviewed
Mar 22, 2024
ergoCubSN001/wrappers/inertials/alljoints-inertials_remapper.xml
Outdated
Show resolved
Hide resolved
Thanks @martinaxgloria! @traversaro, could you give a last pass? |
traversaro
approved these changes
Mar 22, 2024
Thanks @martinaxgloria ! |
MSECode
pushed a commit
to valegagge/robots-configuration
that referenced
this pull request
Apr 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the twin of robotology/icub-models-generator#264. The aim of this PR is to expose via multipleanalogsensorsremapper the orientation measurements of the available IMUs and wrap them in one channel.
The robots involved in these changes are the ergoCubs + the iCubs similar to iCubGenova11, so V2_7. Moreover, I included in the remapper only the IMUs that already have a specific configuration file under
/hardware/inertials/
.Unfortunately, it's difficult to test these changes, but I took #615 as reference that works on iCubGenova11
cc @Nicogene @pattacini @traversaro