-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Attempt to improve the performances of the ctrlLibRT library #143
base: master
Are you sure you want to change the base?
Conversation
Based on my experience, the change in performance also on a custom example that uses those classes as the wbd does may be also a good indication in the increase in the performance. |
Co-authored-by: Prashanth Ramadoss <[email protected]>
Co-authored-by: Prashanth Ramadoss <[email protected]>
I benchmarked the two implementations and I didn't notice any notable timing improvements |
Let's see the bright side. If you have a simple executable it is much easier to profile the code with something like callgrind or flamegraphs |
Removing myself from the reviewers, feel free to add me back if the PR is being worked on. |
As a consequence of #141 I tried to improve the performances of the
⚠️ we should test this PR on the robot to understand if the performances are improved
ctrlLibRT
. Before explaining what I did I would recall that:First of all, I tried to remove the copies from yarp to idyntree, thanks to this choice this code
becomes
iDynTree::toEigen(jointAcc) = filters.jntAccFilter->filt(iDynTree::toEigen(jointAcc));
so I removed two copies every time the joint state is filtered. A similar approach has been used for joint vel, joint acc, accelerometers and gyros, ft.
To achieve that I changed the interface of the
ctrLibRT
to considereigen::ref