Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sending an image through YARP from a web browser fails #38

Open
nunoguedelha opened this issue Mar 30, 2022 · 0 comments
Open

Sending an image through YARP from a web browser fails #38

nunoguedelha opened this issue Mar 30, 2022 · 0 comments
Assignees
Labels

Comments

@nunoguedelha
Copy link
Collaborator

nunoguedelha commented Mar 30, 2022

The problem is with the object type check in the yarp.Image class copy method:

  • For starters there is a bug in the _image.copy wrapper method:

      _image._copy = _image.copy;
      _image.copy = function (obj) {
          if(_image.getObjType == obj.getObjType)
              _image.copy(obj);        <------------------- HERE
          else
              console.log('Error: impossible to copy image');
      }

    _image.copy(obj) should be _image._copy(obj) for calling the original copy method, otherwise we create a infinite loop recursive call.

  • Sending an image sample through YARP from the browser is not properly implemented in the yarp.js package. The problem is bigger than just the object type check failure described earlier. I've opened an issue on yarp.js repo.

Originally posted by @nunoguedelha in ami-iit/yarp-openmct#104 (comment)

Additional details to be added...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant