Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The current state and the future of this library? #239

Open
nemonemi opened this issue Jul 2, 2024 · 8 comments
Open

The current state and the future of this library? #239

nemonemi opened this issue Jul 2, 2024 · 8 comments

Comments

@nemonemi
Copy link

nemonemi commented Jul 2, 2024

Hi guys,
My team is evaluating libraries for handling WebSockets.

Is this library alive? Are there any planned updates?
image

Also, docs seem to be a bit out of sync:
image

@anicioalexandre
Copy link

@nemonemi can't say about the future of the lib, but you can find its releases here https://www.npmjs.com/package/react-use-websocket?activeTab=versions

@nemonemi
Copy link
Author

Hmm, it doesn't give confidence.

Thanks @anicioalexandre for pointing it out.

@robtaussig
Copy link
Owner

robtaussig commented Jul 16, 2024 via email

@anicioalexandre
Copy link

I've been using the lib without any problems so far... Looks like it's being maintained, they just don't sync it too much on the github repo :D
@nemonemi did you find any alternative?

@nemonemi
Copy link
Author

nemonemi commented Aug 7, 2024

Yes, the plain WebSocket e.g. new WebSocket('websocketBackendUrl', 'graphql-transport-ws').

@nemonemi
Copy link
Author

nemonemi commented Aug 7, 2024

What about that screenshot makes you think the docs are out of sync? - Sent from mobile. Please forgive brevity.

No worries.
Well, the first one states that the last "release" was 2 years ago.
The second one says "Version 4.0.0, please install version 3.0.0". This, to me, seemed like, at least, a typo.

@robtaussig
Copy link
Owner

@nemonemi to be honest, I’m not clear on what constitutes a release from GitHub’s perspective, but if you look at npm, I’ve released more recently than 2022. 3.0.0 was from a PR by a contributor — they documented it a bit differently such that it did not get added to the README, but did get captured by GitHub releases.

The second screenshot is meant to convey that 4.0.0 now requires you to use React 18 — if your project is React 17, then you should stick to/install 3.0.0.

@nemonemi
Copy link
Author

nemonemi commented Aug 8, 2024

@robtaussig, I am completely fine with the state of the project being that it is running like a well-oiled steam machine.
I simply pointed out things that stuck out when I was evaluating it.
Usually, the releases on the GitHub repo would reflect the actual list of changes, and the latest version on the releases screen, or there would be a RELEASES.md file or some such way of seeing the latest state of releases and the change log.

Regarding the second screenshot, you are right, it was my oversight.
Happy to close it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants