Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vacuum: a mode that keeps meta data #7

Open
reynir opened this issue Dec 17, 2024 · 1 comment
Open

Vacuum: a mode that keeps meta data #7

reynir opened this issue Dec 17, 2024 · 1 comment

Comments

@reynir
Copy link
Contributor

reynir commented Dec 17, 2024

I think the current implementation removes old builds and artifacts. This may be undesirable as it breaks albatross-client update - which looks up the hash of the currently running unikernel image. If the build has been purged from builder-web it will not be able to find the build (nor any newer images).

So maybe vacuum needs to arguments: how long to keep artifacts? And how long to keep build information? It could for example be 7 days for artifacts and 7 years for build information.

Care should be taken that removing artifacts only doesn't break builder-web.

@hannesm
Copy link
Contributor

hannesm commented Dec 17, 2024

I'm not convinced that we should do this, since it would break the invariant in builder-web that for each build the artifacts are present. Esp. stuff like compare would also not work.

I guess in the presence of vacuum, I'd rather have a "update from " -- so manually providing a job name (to use if the 'find the job from the running unikernel' doesn't work).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

2 participants