Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve the application and introduce paf-le as a standalone package #30

Merged
merged 7 commits into from
Feb 16, 2023

Conversation

dinosaure
Copy link
Contributor

This PR has a minor commit about the application and introduce what we did into paf-le. The main difference is the usage of http-mirage-client as the HTTP client to do HTTP requests to Let's encrypt instead of an handmade hidden module which is an old version of http-mirage-client. The goal is to delete duplication of code and finally use happy-eyeballs as the DNS resolver instead of requiring a gethostbyname.

/cc @hannesm

@hannesm
Copy link
Collaborator

hannesm commented Jan 30, 2023

This looks mostly good. But I hesitate a bit about the module name LE_server -- which is actually the HTTP server for the LE http challenge. My hesitation is that with LE_server I immediately think about the server side of let's encrypt (while this is the HTTP server side for the LE client side).

Would LE_http_server or LE_http be a fine module name?

mirage/lE.ml Outdated Show resolved Hide resolved
mirage/lE.ml Outdated Show resolved Hide resolved
@hannesm
Copy link
Collaborator

hannesm commented Feb 6, 2023

Thanks @dinosaure, only some minor comments. Good to be merged.

To avoid confusion:

ALPN is still used in here for HTTP 1.1 and HTTP 2 support :)

@hannesm
Copy link
Collaborator

hannesm commented Feb 16, 2023

Thanks, I'll merge this now, but wait for a release until the big split [tm] has settled.

@hannesm hannesm merged commit 41f484b into robur-coop:master Feb 16, 2023
@dinosaure dinosaure deleted the improve branch February 16, 2023 16:04
hannesm added a commit to hannesm/opam-repository that referenced this pull request Feb 17, 2023
…tsencrypt-app (0.5.0)

CHANGES:

* adapt to mirage-crypto-rng 0.11.0 API changes (@hannesm)
* upgrade bin/oacmel with cmdliner 1.1.0 (robur-coop/ocaml-letsencrypt#30 @dinosaure)
* add new letsencrypt-mirage package (robur-coop/ocaml-letsencrypt#30 @dinosaure)
* export HTTP_client module directly (robur-coop/ocaml-letsencrypt#30 @dinosaure)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants