-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve the application and introduce paf-le
as a standalone package
#30
Conversation
This looks mostly good. But I hesitate a bit about the module name Would LE_http_server or LE_http be a fine module name? |
Thanks @dinosaure, only some minor comments. Good to be merged. To avoid confusion:
ALPN is still used in here for HTTP 1.1 and HTTP 2 support :) |
Thanks, I'll merge this now, but wait for a release until the big split [tm] has settled. |
…tsencrypt-app (0.5.0) CHANGES: * adapt to mirage-crypto-rng 0.11.0 API changes (@hannesm) * upgrade bin/oacmel with cmdliner 1.1.0 (robur-coop/ocaml-letsencrypt#30 @dinosaure) * add new letsencrypt-mirage package (robur-coop/ocaml-letsencrypt#30 @dinosaure) * export HTTP_client module directly (robur-coop/ocaml-letsencrypt#30 @dinosaure)
This PR has a minor commit about the application and introduce what we did into
paf-le
. The main difference is the usage ofhttp-mirage-client
as the HTTP client to do HTTP requests to Let's encrypt instead of an handmade hidden module which is an old version ofhttp-mirage-client
. The goal is to delete duplication of code and finally usehappy-eyeballs
as the DNS resolver instead of requiring agethostbyname
./cc @hannesm