Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Version check is broken on dev versions #299

Open
aantn opened this issue Jun 20, 2024 · 0 comments
Open

Version check is broken on dev versions #299

aantn opened this issue Jun 20, 2024 · 0 comments

Comments

@aantn
Copy link
Contributor

aantn commented Jun 20, 2024

The error only appears when running with --verbose - otherwise it is a quiet failure. So this isn't urgent to fix.

(krr) ➜  krr git:(patching_pod_conditions) python ./krr.py simple --verbose                           
 _____       _               _          _  _______  _____
|  __ \     | |             | |        | |/ /  __ \|  __ \
| |__) |___ | |__  _   _ ___| |_ __ _  | ' /| |__) | |__) |
|  _  // _ \| '_ \| | | / __| __/ _` | |  < |  _  /|  _  /
| | \ \ (_) | |_) | |_| \__ \ || (_| | | . \| | \ \| | \ \
|_|  \_\___/|_.__/ \__,_|___/\__\__,_| |_|\_\_|  \_\_|  \_\
Thanks for using Robusta KRR. If you have any questions or feedback, please feel free to reach out to us at
https://github.com/robusta-dev/krr/issues
Running Robusta's KRR (Kubernetes Resource Recommender) 1.10.0-alpha-7-g75efd74-patching_pod_conditions
Using strategy: Simple
Using formatter: table
[13:58:45] DEBUG    An error occurred while checking for a new version                                                                                                          runner.py:85
                    Traceback (most recent call last):                                                                                                                                      
                      File "/home/pavan/Documents/Work/krr/robusta_krr/core/runner.py", line 79, in __check_newer_version_available                                                         
                        current_version_parsed = self.__parse_version_string(current_version)                                                                                               
                                                 ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^                                                                                               
                      File "/home/pavan/Documents/Work/krr/robusta_krr/core/runner.py", line 75, in __parse_version_string                                                                  
                        return tuple(map(int, version_trimmed.split(".")))                                                                                                                  
                               ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^                                                                                                                  
                    ValueError: invalid literal for int() with base 10: '0-alpha-7-g75efd74-patching_pod_conditions'                                                                        
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant