Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add the link-preview-js dependency #154

Open
Juddex0 opened this issue Nov 29, 2024 · 3 comments
Open

Add the link-preview-js dependency #154

Juddex0 opened this issue Nov 29, 2024 · 3 comments

Comments

@Juddex0
Copy link

Juddex0 commented Nov 29, 2024

hi, I'm relatively new to this, but is it possible if you could add the link-preview-js depedency to the mudslide repo ?

So that everytime I send a link to my whatsapp contacts, they can see the thumbnail preview of the link sent, thank you :)

@robvanderleek
Copy link
Owner

Hi @Juddex0

Thanks for your input.

Adding URL previews has been discussed before in this issue: #113
Please go through that issue thread, and if you're able, try the issue branch.
As you can read, the functionality does not work on all platforms, and the reason for that is outside the scope of this repository.

@Juddex0
Copy link
Author

Juddex0 commented Nov 30, 2024

Thanks @robvanderleek I have taken a look at the issue thread and if I am understanding correctly, it only works on ios but doesn't work on android.

If I clone the mudslide repo to my local machine in VScode and modify the files,

how do I tell npx to use the mudslide version from my local machine instead of the default one from github ?

Thank you

@robvanderleek
Copy link
Owner

Thanks @robvanderleek I have taken a look at the issue thread and if I am understanding correctly, it only works on ios but doesn't work on android.

Yes. Also, I can only test on iOS myself.

If I clone the mudslide repo to my local machine in VScode and modify the files,
how do I tell npx to use the mudslide version from my local machine instead of the default one from github ?

To run it locally from a cloned repository, you can best use Yarn. I've updated the development documentation a bit: https://github.com/robvanderleek/mudslide?tab=readme-ov-file#development

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants