Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

How to use ImageView.h from other libraries? #26

Open
chhtz opened this issue Oct 19, 2017 · 1 comment
Open

How to use ImageView.h from other libraries? #26

chhtz opened this issue Oct 19, 2017 · 1 comment

Comments

@chhtz
Copy link
Member

chhtz commented Oct 19, 2017

Just doing #include <rock_widget_collection/ImageView.h> and adding rock_widget_collection as a DEPS_PKGCONFIG won't work, because, ImageView.h includes rock_widget_collection/progress_indicator/ProgressIndicator.h, which actually gets installed to ${INCLUDE_DIR}/rock_widget_collection/ProgressIndicator.h and GraphicsPointsItem.h which does not get installed.

The latter issue should be easy to fix, for the first I don't see an obvious fix (without breaking the build of rock_widget_collection on a fresh install) ...

@doudou
Copy link
Member

doudou commented Oct 19, 2017

There does not seem to be an easy fix, unfortunately. The obvious (but non-trivial) fix would be to fix the cmake macros to install the headers in the right subdirectory.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants