fix: validate that the "old" part of a reconfigured pair will get garbage collected #358
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ions While the normal data structure does not generate this type of patterns, they must be supported - it is generally speaking useful, and is already used by e.g. the transformer to represent dynamic transformation producers. The pattern obviously already triggered a bug since there was a specific bug fix for a task context->task context dependency. The fix was however too limited as it would not handle task context->composition. This change implements a pass after deployment where we would find the root components from the "old plan" that are not used in the "new plan", and cut the dependency relations between these two. This should really handle all cases.
…l deployment stages finalize_deployed_tasks split between reused and new tasks, while reconfigure_tasks_on_static_port_modification only had one "deployed tasks". It was pretty confusing (even if the two get merged at the end)
…bage collected This makes explicit an internal error, and avoids that the system blindly "waits" for the task to finally do what it should.
afonsofonbraga
approved these changes
May 16, 2023
jhonasiv
approved these changes
May 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On top of #357
This commit is to essentially avoid the silent failure. With this change, Syskit will kill the old task, with the likely
effect of actually killing the main action. But better than blindly waiting (maybe ?)
I put it onto a separate pull request to get a bit more time with it before we merge, making sure there are no
unintended consequences, while #357 is, I believe, safe.