[WIP] feat: capture errors that shouldnt cause the whole plan to be discarded during network resolution #444
+288
−138
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jhonasiv
force-pushed
the
capture-errors
branch
2 times, most recently
from
ec71d41 to
d0b83eb
Compare
We introduced a ResolutionError to mark errors during the new plan network resolution shouldnt be raised, which causes the whole transation to fail. Instead, we capture them and fail the deployment of the specific tasks that caused them.
Ensures that the system will treat the failed tasks accordingly.
jhonasiv
force-pushed
the
capture-errors
branch
from
d0b83eb to
63070d9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We introduced a ResolutionError to mark errors during the new plan
network resolution shouldnt be raised, which causes the whole transation
to fail. Instead, we capture them and fail the deployment of the
specific tasks that caused them.