WIP chore: early deploy at network generation #445
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This became a necessity as we pretend to do early deployments at network generation. In this scenario, when a "free" task context is merged into its deployed counter part its plan marks is not carried out to the deployment task instance. Then, this task instance would be garbage collected because it did not carried the permanent mark from the replace "free" task context
wvmcastro
force-pushed
the
early-deploy-on-generation
branch
from
892b048 to
781d6c2
Compare
validate_generated_network had no args previously, so every equivalent plugin implementation does not have it as well
wvmcastro
force-pushed
the
early-deploy-on-generation
branch
from
781d6c2 to
e925c62
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On top of:
Depends on:
Opening this PR for getting a CI run with test failures and an early request for comments