SQLAlchemy dialect?

[betodealmeida]

Hi, folks!

I saw the new release and went to bump the version on Apache Superset, but I noticed that since 1.0 it no longer ships with a SQLAlchemy dialect. Any reason for that? Are there plans to create a dialect? Do you need help?

Thanks!

[jhochmuth]

Hi, sorry this took a while to respond. The reason it wasn't included was that the focus on the 1.0 version of the client was autogeneration. We decided to leave some things out of the new client in order to achieve a client that could be updated with almost no manual work. Currently, we aren't actively working on adding the dialect. I talked to product and we of course won't discourage people from working on anything if they want, although I'm leaning towards having the sqlalchemy dialect in its own repo and library unless it is more of a common pattern to have them included together

[betodealmeida]

@jhochmuth having separate packages for the DB API 2 library and the SQLAlchemy dialect is not uncommon. I'd be happy to work on updating the old SQLAlchemy dialect to work with the v1 client and maintaining it as a separate project, to prevent Superset users from being stuck in the 0.9 version.

[betodealmeida]

@jhochmuth can you confirm which license is used for the client? The project page on PyPI says it's BSD, but I couldn't find any info in the repo other than the classifier for PyPI:

rockset-python-client/pyproject.toml

Line 14 in 52f63e8

"License :: OSI Approved :: BSD License",

Thanks!

[jhochmuth]

That would be great! Thanks, we really appreciate it. Let me double check with some product people about licenses – I basically just copied some of the stuff from the older versions so I'm not completely sure myself.

[jhochmuth]

Ok, the recommendation I received was Apache 2.0. I'm going to update the license on this as well to reflect that.

[betodealmeida]

Ah, thanks! This means I can fork the dialect from the 0.9 version and make it work with 1.0, instead of writing everything from scratch.