Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Explore convenience and usability of vfs_snapper for Samba shadow copies #2557

Open
FroggyFlox opened this issue May 24, 2023 · 3 comments
Open

Comments

@FroggyFlox
Copy link
Member

Samba now has a snapper vfs module:
https://www.samba.org/samba/docs/current/man-html/vfs_snapper.8.html

As described there:

The vfs_snapper VFS module exposes snapshots managed by snapper for use by Samba. This provides the ability for remote SMB clients to access shadow-copies via Windows Explorer using the "previous versions" dialog.

A very nice and detailed description and set of instructions are in the Leap 15.4 docs:
https://doc.opensuse.org/documentation/leap/reference/html/book-reference/cha-samba.html#sec-samba-advanced-snapshots-client

We currently support this functionality using the shadow_copy_2 vfs module but it requires a bit of configuration that makes it prone to errors (https://rockstor.com/docs/howtos/windows-shadow-copy.html).

Although we do not have snapper integrated in Rockstor, it is there and running (used by our upstream bits). It would thus be worth looking into the benefits of using vfs_snapper to manage shadow copies in Samba.

Note that this would (most likely) be in combination with #2136.

@FroggyFlox
Copy link
Member Author

FroggyFlox commented May 24, 2023

A first potential obstacle I see, though: from the manual: https://www.samba.org/samba/docs/current/man-html/vfs_snapper.8.html

Snapper stores snapshots under a .snapshots subdirectory.

From this, I understand we would need to have our snapshots for such volumes stored under a .snapshots dir... In other words, we would need to have snapper create the snapshots for a share exported by Samba.

@phillxnet
Copy link
Member

@FroggyFlox Nice find. I think we need to revisit the work done by @sfranzen here:

#1491

which is now very outdated, and in-turn required a backbone jslib update rockstor/rockstor-jslibs#8

@FroggyFlox
Copy link
Member Author

It turns out I (again) did not do enough research before posting this. There have been multiple references to that vfs module here (including by myself):

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants