Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

official debian package? #31

Open
anarcat opened this issue Feb 14, 2024 · 9 comments
Open

official debian package? #31

anarcat opened this issue Feb 14, 2024 · 9 comments

Comments

@anarcat
Copy link

anarcat commented Feb 14, 2024

Hi!

Thanks for this interesting package. Have you considered submitting it to Debian directly?

I'm working on auditing the code and packaging it myself, but i'm happy to have you as a maintainer and just sponsor your uploads, or have you as a co-maintainer, as you wish!

@anarcat anarcat mentioned this issue Feb 14, 2024
@anarcat
Copy link
Author

anarcat commented Feb 14, 2024

i have submitted the Debian package into the Debian archive. the Git repository tracking my work is available here:

https://salsa.debian.org/debian/pass-extension-update

It has small cosmetic changes to the debian/ directory and I added a patch to fix bash completion (#25), which is already in git here (8721eb0).

The Debian bug tracking this issue is in #1063912.

It would be great to have a new release upstream to remove that patch (#32)!

Let me know if you want to maintain the Debian package going forward. For now, I've made myself maintainer, but we can perfectly keep this repository here as the canonical copy instead, and I would then just "sponsor" your uploads (which basically means I review the diff, build the package, sign it with my PGP key and upload it).

Let me kno!

@roddhjav
Copy link
Owner

Hi, thanks, yes a new release is coming (alongside with pass-import and pass-audit), I only have some time constraint at the moment.

I will gladly co-maintain/maintain the package for Debian if I can.

@anarcat
Copy link
Author

anarcat commented Feb 15, 2024

oh hi! :)

so i've submitted the package in Debian already. i'm happy to tweak it to add you as a co-maintainer, or make you a maintainer, at your preference. otherwise, we can just keep things this way and i'll follow you closely, don't worry. :)

the package is now waiting in the NEW queue for admission / review. you can see it here:

https://ftp-master.debian.org/new/pass-update_2.1-1.html

@roddhjav
Copy link
Owner

Co-maintaining will be fine for now (I don't have that much experience in Debian packaging). I will try to make a new release over the week end.

@roddhjav
Copy link
Owner

@anarcat would you have any recommendation about the best (modern) way to build/package pass-update?

According to roddhjav/pass-audit#32 installing data file with setup.py is not the best solution. But such a construction would break install from pip, which is an issue.

@anarcat
Copy link
Author

anarcat commented Feb 18, 2024

i'll take a look and comment over there, it's a common problem and i think i probably have solutions over here. :)

@anarcat
Copy link
Author

anarcat commented Feb 27, 2024

hmm... so i've tried to build the 2.2 release and i think it's broken. lintian is complaining with:

E: pass-extension-update: file-directly-in-usr-share [usr/share/__main__.py]

it looks like the main file doesn't get installed correctly... any idea what might have caused this regression?

@roddhjav
Copy link
Owner

Dam, thanks for this catch. My mistake, the new makefile installed by default this new file. It is a simple dev script that automate the release process, it should obviously not have been packaged.

@roddhjav
Copy link
Owner

This is now fixed. Once I get the solution regarding the completion, I will create a new release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants