Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mark Tags as Releases #289

Open
tedivm opened this issue Mar 24, 2015 · 8 comments
Open

Mark Tags as Releases #289

tedivm opened this issue Mar 24, 2015 · 8 comments

Comments

@tedivm
Copy link

tedivm commented Mar 24, 2015

According to Github the last, and currently stable, release was v0.9.17. Since then you've stopped issuing new Github releases and are simply tagging thing.

This is obviously an extremely minor issue, but it would help people who are using the Github API or even just people who happen to browse over here.

@carlossg
Copy link
Collaborator

1.5.0 and 2.1.0 show up in https://github.com/rodjek/librarian-puppet/releases

@tedivm
Copy link
Author

tedivm commented Apr 24, 2015

Gthub puts tags into the release section by default, but does not mark them as a current release unless you actually go in and turn them into a release.

If you go to the 0.9.2 release page you'll see a big green icon that says "latest release"-
https://github.com/rodjek/librarian-puppet/releases/tag/v0.9.17

If you browse the release you'll see that v0.9.17 is marked as "latest"-
https://github.com/rodjek/librarian-puppet/releases?after=v1.1.0

Finally, if you're using the github API to find out what the current release is you are getting v0.9.17 instead of 1.5 or 21.

@njam
Copy link
Contributor

njam commented Apr 24, 2015

Github releases are overrated ;)

@tedivm
Copy link
Author

tedivm commented Apr 24, 2015

Whatever. I just thought you guys could make it easier for people who are pulling info about the project from the github api. If you don't care about those people than that's your problem.

@njam
Copy link
Contributor

njam commented Apr 24, 2015

If one only has tags, will those be returned by the Github releases API? Or does it only work if you have actual releases?

@carlossg
Copy link
Collaborator

I think I'm going to stick to tags, seems that marking releases involves going to each tag and doing it which is quite inconvenient

@tedivm
Copy link
Author

tedivm commented Apr 24, 2015

If you don't mark them as releases then the release API will return blank, which is actually good if you're not actually using releases- it would tell people you're not using them and allow them to fall back with tags.

Github's API is rest based, so you can see the results just by plugging in URLs-

https://api.github.com/repos/rodjek/librarian-puppet/releases

If you guys aren't actually using releases then you should remove the releases you have created (which appear to just be v0.9.13 through v0.9.17).

@tedivm
Copy link
Author

tedivm commented Apr 24, 2015

@carlossg, that's fine, but you should fix the releases you've already made (by removing them as releases but not as tags). We've already talked about this issue longer than it would take you to clean it up.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants