Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Failing unit test for maxOccupationtime #57

Open
rogierschouten opened this issue Oct 29, 2022 · 1 comment
Open

Failing unit test for maxOccupationtime #57

rogierschouten opened this issue Oct 29, 2022 · 1 comment

Comments

@rogierschouten
Copy link
Owner

Hi @abozaralizadeh and @ThePiz apparently it slipped our attention but the unit test for maxOccupationtTime fails rightfully. Any chance for you to check this out?

@mottymilshtein
Copy link

@rogierschouten I have just seen this issue and I believe you miss understood me about the issue I described with maxOccupationTime parameter, I didn't mean there is an issue with the tests (as far as I can see they all pass).
I meant to say that there is a logical issue with this parameter: if options are passed through the acquire method for the same key if the first function to run passes maxOccupationTime parameter and the second does not then in case the first functions timer throws the exception during the execution then the second function will be blocked in await forever (it doesn't have a timeout) and the queue will not be purged as well.

p.s. when you replied about the tests I assumed you meant you'll add a test for that

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants