Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cookie authentication uploading will stop working for places #926

Open
ThatTimothy opened this issue Jun 12, 2024 · 1 comment
Open

Cookie authentication uploading will stop working for places #926

ThatTimothy opened this issue Jun 12, 2024 · 1 comment
Assignees
Labels
scope: cli Relevant to the Rojo CLI type: enhancement Feature or improvement that should potentially happen type: tech debt Internal work that needs to happen

Comments

@ThatTimothy
Copy link

Per https://devforum.roblox.com/t/official-list-of-deprecated-web-endpoints/62889/62:

As of June 24th, we plan to stop supporting place asset uploads on data.roblox.com/Data/Upload.ashx . After this day, we will start rejecting place traffic on this endpoint. It will still be usable for other assets.

We recommend transitioning to our Open Cloud Place Upload for all future place asset uploads. Detailed documentation can be found here: Usage Guide for Place Publishing | Documentation - Roblox Creator Hub

Thanks for your continuing support and let us know if you have any concerns.

Usage here, when using cookie authentication:

rojo/src/cli/upload.rs

Lines 120 to 125 in a7b45ee

fn do_upload(buffer: Vec<u8>, asset_id: u64, cookie: &str) -> anyhow::Result<()> {
let url = format!(
"https://data.roblox.com/Data/Upload.ashx?assetid={}",
asset_id
);

While open cloud is an easy alternative and what most people should be using, we probably want to at least issue a warning that using a cookie only to upload will stop working on June 24th, and eventually remove this functionality since it won't work anymore.

@Dekkonot
Copy link
Member

Thanks for opening an issue. My plan was to change this to error if you were trying to upload a place file (so a Rojo project that had a DataModel at the root) but otherwise leave it unchanged. This is because there's currently no replacement endpoint for uploading models or plugins, which is something of a blocker for outright removing this endpoint.

@Dekkonot Dekkonot added type: enhancement Feature or improvement that should potentially happen scope: cli Relevant to the Rojo CLI type: tech debt Internal work that needs to happen labels Jun 12, 2024
@Dekkonot Dekkonot self-assigned this Jun 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
scope: cli Relevant to the Rojo CLI type: enhancement Feature or improvement that should potentially happen type: tech debt Internal work that needs to happen
Projects
None yet
Development

No branches or pull requests

2 participants