From 1c6dcf4917b332c3f5301a023867422d87c19e35 Mon Sep 17 00:00:00 2001 From: Bronley Plumb Date: Thu, 26 Sep 2024 16:06:38 -0400 Subject: [PATCH] Better error message wording --- src/LanguageServerManager.ts | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/LanguageServerManager.ts b/src/LanguageServerManager.ts index c4e65560..1fcda1fe 100644 --- a/src/LanguageServerManager.ts +++ b/src/LanguageServerManager.ts @@ -423,8 +423,8 @@ export class LanguageServerManager { this.selectedBscInfo = await this.ensureBscVersionInstalled(versionInfo); } catch (e) { console.error(e); - //fall back to the embedded version, and show a popup - await vscode.window.showErrorMessage(`Can't find language server for "${versionInfo}". Did you forget to run \`npm install\`? Using embedded version v${this.embeddedBscInfo.version} instead.`); + //fall back to the embedded version, and show a popup (don't await the popup because that blocks this flow) + void vscode.window.showErrorMessage(`Language server failure. Did you forget \`npm install\`? Using embedded version ${this.embeddedBscInfo.version}. Can't find language server for "${versionInfo}"`); this.selectedBscInfo = this.embeddedBscInfo; }