-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Extension keeps running after closing vscode with 100% cpu use #486
Comments
I believe we fixed this issue (or most of it), in |
@TwitchBronBron It is not fixed for me on 2.40.4. There is still process left behind that keeps running and consuming one whole thread (maybe not obvious in the image since at that moment it was switching the load to second thread) |
Some logs I got at the moment of closing vscode (around 2023-05-24 21:45:28.917)(probably not related): File exthost.log
|
@DusanLesan are you still encountering this issue? If so, how severe is it. Does it prevent debugging from working? Are you finding that you have to kill the process regularly? |
I have tried now the latest version and the issue is still actual. I have stopped the auto updates since it was bad enough for me. I could still debug but I would rather use 2.39.0 than deal with the rogue processes every day |
@TwitchBronBron Any progress on this? I have experienced this issue on my new computer too but since it uses the same setup as previous (arch + X + dwm + code OSS + plugin from open-vsx.org), I have also tried it in a virtual machine using ubuntu 22.04 with vscode from store and debugging an app from rokudev/samples |
Sadly I haven't had the time to investigate lately. Does this reproduce every single time for you? To help troubleshoot this issue, we added some better logging a while back. Could you do the following:
|
2023-09-13T14∶49∶29-debugger.log Yes, it happens for me every time I close vscode while debugger is running |
Just a quick update: we've found several places in the debugger logic where we aren't properly shutting down some things (event listeners, long-lived telnet connections, etc). rokucommunity/roku-debug#161 and rokucommunity/roku-debug#107 should include those fixes (and I have a few more locally that will go into them before they merge). So i'll report back when they're ready to test. Hopefully we've found and squashed the root cause of these issues for you soon! |
@DusanLesan release v2.44.0 introduced several fixes that attempt to address this issue. Can you try that out and report back? |
Starting with the version
2.40.1
, plugin is no longer closed after exiting vscode on linux. Furthermore, the extension starts utilizing 100% of one cpu thread.In this image, you can see plugin getting left behind seconds after closing vscode. Sometimes, I have even seen several different plugin tasks running after closing vscode
v
2.40.0
and before it worked fineSTR:
vscode info:
Version: 1.78.2
Commit: b3e4e68a0bc097f0ae7907b217c1119af9e03435
Date: 2023-05-12T07:29:20.595Z
Electron: 22.3.3
Chromium: 108.0.5359.215
Node.js: 16.17.1
V8: 10.8.168.25-electron.0
OS: Linux x64 6.3.3-arch1-1
Sandboxed: No
The text was updated successfully, but these errors were encountered: