Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Add web support for embeds #4719

Closed
wants to merge 1 commit into from

Conversation

manav2modi
Copy link
Contributor

@manav2modi manav2modi commented Feb 3, 2025

Description

I am changing the plugin we are using because the other one does not work on web and this one should work on ios, android and web

Fixes #4718

Review Time Estimate

Please give your idea of how soon this pull request needs to be reviewed by selecting one of the options below. This can be based on the criticality of the issue at hand and/or other relevant factors.

  • Immediately
  • Within a week
  • When possible

Type of changes

Please select a relevant option:

  • Bug fix (non-breaking change which fixes an issue).
  • New feature (non-breaking change which adds functionality).
  • Breaking change (fix or feature that would cause existing functionality to not work as expected).
  • Other (any another change that does not fall in one of the above categories.)

Checklist:

Please select all applicable options:

  • I have signed the Rokwire Contributor License Agreement (CLA). (Any contributor who is not an employee of the University of Illinois whose official duties include contributing to the Rokwire software, or who is not paid by the Rokwire project, needs to sign the CLA before their contribution can be accepted.)
  • I have updated the CHANGELOG.
  • I have read the Contributor Guidelines.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • My change requires updating the documentation.
  • I have made necessary changes to the documentation.
  • I have added tests related to my changes.
  • My changes generate no new warnings.
  • New and existing unit tests pass locally with my changes.
  • Any dependent changes have been merged and published in downstream modules.

@manav2modi manav2modi linked an issue Feb 3, 2025 that may be closed by this pull request
@dobromirdobrev dobromirdobrev self-requested a review February 7, 2025 09:05
@dobromirdobrev
Copy link
Collaborator

Hi @manav2modi ,

First, I would like to thank you for your work in this task.

However, I will close this PR without merging it for a few of reasons:

  1. Since it is for fixing something for the web app, it is good the PR to be against the relevant branch for the web app feature/web but not against develop branch.
  2. I've checked this easy_web_view plugin and it does not work for the web platform (even though that it is claimed in the docs). It crashes and and we are not able to show the relevant list as well.
  3. I've checked the source code of the plugin and they use dart packages that do not work for web. This could be one of the reasons but either way the result is that it does not work for web.

So, having in mind the above, I'm closing this PR without merging it into our source code.

Please let me know if you have any questions or comments. Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] Add web support for embeds
2 participants