From a491d74e4f7d14ce1a14319f0da7a2dbf901c25c Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Mikel=20Mart=C3=ADn?= <mikel@moodle.com>
Date: Mon, 14 Oct 2024 16:07:23 +0200
Subject: [PATCH] MDL-83457 mod_feedback: Fix 'feedback_get_incomplete_users'
 early return type

Fix 'feedback_get_incomplete_users' early return when there are no users with
the 'mod/feedback:complete' capability from 'false' to an empty array. That
will follow the function signature.
---
 mod/feedback/lib.php | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/mod/feedback/lib.php b/mod/feedback/lib.php
index 19f6c06ceabf1..436d24e92a301 100644
--- a/mod/feedback/lib.php
+++ b/mod/feedback/lib.php
@@ -975,7 +975,7 @@ function feedback_get_incomplete_users(cm_info $cm,
                                             $group,
                                             '',
                                             true)) {
-        return false;
+        return [];
     }
     // Filter users that are not in the correct group/grouping.
     $info = new \core_availability\info_module($cm);