From c5ee19b29c7b6a55606f685614a74bc0b2313b3b Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Mikel=20Mart=C3=ADn?= <mikel@moodle.com>
Date: Fri, 8 Sep 2023 14:45:05 +0200
Subject: [PATCH] MDL-77804 reportbuilder: Improve horizontal filter forms UI

- Separate Inline forms styles in a different section and improve them
- Re-organize the styles and comments to improve readability and mantainability
- Make defined variables overridable
---
 .../templates/local/filters/header.mustache   |   2 +-
 theme/boost/scss/moodle/reportbuilder.scss    | 287 ++++++++++--------
 theme/boost/style/moodle.css                  | 223 +++++++-------
 theme/classic/style/moodle.css                | 223 +++++++-------
 4 files changed, 362 insertions(+), 373 deletions(-)

diff --git a/reportbuilder/templates/local/filters/header.mustache b/reportbuilder/templates/local/filters/header.mustache
index c6492bc12db9a..5a3bf473e14ef 100644
--- a/reportbuilder/templates/local/filters/header.mustache
+++ b/reportbuilder/templates/local/filters/header.mustache
@@ -24,7 +24,7 @@
         "name": "Date modified"
     }
 }}
-<div class="filter pb-4 mb-3 border-bottom" data-filter-for="{{name}}">
+<div class="filter pb-3 mb-3 border-bottom" data-filter-for="{{name}}">
     <div class="filter-header d-flex align-items-start justify-content-between">
         <div class="filter-name">
             {{{name}}}
diff --git a/theme/boost/scss/moodle/reportbuilder.scss b/theme/boost/scss/moodle/reportbuilder.scss
index abed4b5eddff5..dc6ca46a939c4 100644
--- a/theme/boost/scss/moodle/reportbuilder.scss
+++ b/theme/boost/scss/moodle/reportbuilder.scss
@@ -1,8 +1,25 @@
 /**
-* Reportbuilder.
+* Reportbuilder styles.
 */
 
-/* Table */
+//
+// General styles
+//
+
+// Button styles when a toggle button is active.
+.reportbuilder-wrapper {
+    .btn-outline-secondary[data-toggle="collapse"]:not(.collapsed),
+    .dropdown.show .btn-outline-secondary[data-toggle="dropdown"] {
+        color: color-yiq($gray-600);
+        background-color: $gray-600;
+        border-color: $gray-600;
+    }
+}
+
+//
+// Table
+//
+
 .reportbuilder-table {
     td {
         @extend .align-middle;
@@ -12,71 +29,134 @@
     }
 }
 
-/* Filters */
-.reportbuilder-wrapper {
-    .filters-dropdown {
-        width: 27rem;
-        padding: 0;
-        z-index: $zindex-modal;
-        overflow: hidden;
-        @include media-breakpoint-down(sm) {
-            width: 100%;
-        }
-        .reportbuilder-filters-sidebar {
-            max-height: calc(100vh - #{$navbar-height} - 1rem);
-            overflow-y: auto;
-            @include thin-scrolls($white);
-        }
+//
+// Filters
+//
+
+$rb-filters-dropdown-width: 27rem !default;
+
+.reportbuilder-wrapper .filters-dropdown {
+    width: $rb-filters-dropdown-width;
+    padding: 0;
+    z-index: $zindex-modal;
+    overflow: hidden;
+    @include media-breakpoint-down(sm) {
+        width: 100%;
     }
-    .reportbuilder-filters-wrapper,
-    .reportbuilder-conditions-list {
-        .mform {
-            &.full-width-labels {
-                .fitem.row {
-                    > .col-md-3,
-                    > .col-md-9 {
-                        flex: 0 0 100%;
-                        max-width: 100%;
-                    }
-                    .fdate_selector {
-                        flex-wrap: wrap;
-                    }
-                }
+}
+.reportbuilder-filters-sidebar {
+    max-height: calc(100vh - #{$navbar-height} - 1rem);
+    overflow-y: auto;
+    @include thin-scrolls($white);
+    .filter {
+        .filter-header {
+            font-size: $h5-font-size;
+            .filter-name {
+                font-size: $font-size-base;
+                white-space: nowrap;
+                overflow: hidden;
+                text-overflow: ellipsis;
+                padding-right: map-get($spacers, 3);
             }
-            .form-group {
-                margin-bottom: 0;
-                max-width: 100%;
-                > span {
-                    max-width: 100%;
-                }
+            .filter-name:hover {
+                white-space: normal;
+                text-overflow: clip;
+                word-break: break-all;
             }
         }
-        .filter {
-            .filter-header {
-                font-size: $h5-font-size;
-                .filter-name {
-                    font-size: 1rem;
-                    white-space: nowrap;
-                    overflow: hidden;
-                    text-overflow: ellipsis;
-                    padding-right: 1rem;
-                }
-                .filter-name:hover {
-                    white-space: normal;
-                    text-overflow: clip;
-                    word-break: break-all;
-                }
+    }
+}
+
+//
+// Inline forms
+//
+
+.reportbuilder-filters-wrapper,
+.reportbuilder-conditions-list {
+    .mform.full-width-labels {
+        .fdate_selector {
+            flex-wrap: wrap;
+        }
+        .form-group {
+            margin-bottom: 0;
+            max-width: 100%;
+        }
+        .form-group:not(.row):last-child {
+            flex: 1;
+            min-width: 0;
+            span,
+            .custom-select {
+                width: 100%;
             }
         }
     }
 }
 
-/**
-* Custom Reports.
-*/
+//
+// Custom Reports
+//
+
+$rb-left-sidebar-width: 250px !default;
+$rb-right-sidebar-width: 350px !default;
 
-$rb-left-sidebar-width: 250px;
-$rb-right-sidebar-width: 350px;
+// Reportbuilder full page layout
+
+@include media-breakpoint-up(lg) {
+    $tabs-height: 83px;
+    $sidebar-margin-top: $navbar-height + $tabs-height + 20px;
+    .path-admin-reportbuilder.pagelayout-popup {
+        // Fix for behat-site defined in theme/boost/scss/moodle/debug.scss:7 is not needed. Override it.
+        &.behat-site .fixed-top {
+            position: fixed;
+        }
+        #region-main {
+            border: none;
+            padding: 0;
+        }
+        #maincontent {
+            visibility: hidden;
+        }
+        .dynamictabs .nav-tabs {
+            position: fixed;
+            z-index: $zindex-fixed;
+            width: calc(100% - 35px);
+            padding-top: 1.25rem;
+            background-color: $white;
+            // Small hack to simulate padding bottom after nav-tabs border.
+            box-shadow: 0 1.25rem 0 $white;
+        }
+        .dynamictabs .tab-content {
+            padding-top: $tabs-height;
+        }
+        .reportbuilder-sidebar-menu {
+            position: fixed;
+            .reportbuilder-sidebar-menu-cards {
+                max-height: calc(100vh - #{$sidebar-margin-top} - 52px); // 52px corresponds to "search" input size.
+            }
+        }
+        .reportbuilder-sidebar-settings {
+            position: fixed;
+            right: 30px;
+            max-height: calc(100vh - #{$sidebar-margin-top});
+        }
+        .reportbuilder-report[data-editing] .reportbuilder-report-container {
+            max-height: calc(100vh - #{$sidebar-margin-top});
+            overflow-y: auto;
+            @include thin-scrolls($gray-100);
+            margin-left: calc(#{$rb-left-sidebar-width} + 1rem);
+            margin-right: calc(#{$rb-right-sidebar-width} + 1rem);
+        }
+        .reportbuilder-audiences-container {
+            margin-left: calc(#{$rb-left-sidebar-width} + 1rem);
+        }
+    }
+}
+// Fix popper.js behaviour in fullpage report (using 'popup' page layout).
+#page-admin-reportbuilder-edit #page {
+    overflow-y: auto;
+}
+
+// Main content in "Editor" tab (report table)
 
 .reportbuilder-report-container {
     @extend .flex-fill;
@@ -89,8 +169,7 @@ $rb-right-sidebar-width: 350px;
 .reportbuilder-editor-table-container {
     overflow-x: auto;
 }
-
-/* Custom table headers */
+// Custom table headers.
 .reportbuilder-table th {
     button[data-action="report-remove-column"],
     span[data-drag-type="move"] {
@@ -107,7 +186,8 @@ $rb-right-sidebar-width: 350px;
     }
 }
 
-/* Sidebar menu */
+// Left sidebar menu in "Editor" tab (columns)
+
 .reportbuilder-sidebar-menu {
     @include media-breakpoint-up(lg) {
         width: $rb-left-sidebar-width;
@@ -127,7 +207,8 @@ $rb-right-sidebar-width: 350px;
     @include thin-scrolls($gray-100);
 }
 
-/* Settings sidebar */
+// Right sidebar menu in "Editor" tab  (settings)
+
 .reportbuilder-sidebar-settings {
     overflow-y: auto;
     @include thin-scrolls($gray-100);
@@ -172,17 +253,8 @@ $rb-right-sidebar-width: 350px;
     }
 }
 
-/* Add button styles when a toggle button is active. */
-.reportbuilder-wrapper {
-    button.btn-outline-secondary[data-toggle="collapse"]:not(.collapsed),
-    .dropdown.show button.btn-outline-secondary[data-toggle="dropdown"] {
-        color: color-yiq($gray-600);
-        background-color: $gray-600;
-        border-color: $gray-600;
-    }
-}
+// Drag&drop styles
 
-/* Drag&drop styles. */
 .reportbuilder-sortable-list li,
 .reportbuilder-table th,
 .reportbuilder-conditions-list .condition {
@@ -195,62 +267,8 @@ $rb-right-sidebar-width: 350px;
     }
 }
 
-/* Reportbuilder full page styles. */
-@include media-breakpoint-up(lg) {
-    $tabs-height: 83px;
-    $sidebar-margin-top: $navbar-height + $tabs-height + 20px;
-    .path-admin-reportbuilder.pagelayout-popup {
-        // Fix for behat-site defined in theme/boost/scss/moodle/debug.scss:7 is not needed. Override it.
-        &.behat-site .fixed-top {
-            position: fixed;
-        }
-        #region-main {
-            border: none;
-            padding: 0;
-        }
-        #maincontent {
-            visibility: hidden;
-        }
-        .dynamictabs .nav-tabs {
-            position: fixed;
-            z-index: $zindex-fixed;
-            width: calc(100% - 35px);
-            padding-top: 1.25rem;
-            background-color: $white;
-            box-shadow: 0 1.25rem 0 $white; // Small hack to simulate padding bottom after nav-tabs border.
-        }
-        .dynamictabs .tab-content {
-            padding-top: $tabs-height;
-        }
-        .reportbuilder-sidebar-menu {
-            position: fixed;
-            .reportbuilder-sidebar-menu-cards {
-                max-height: calc(100vh - #{$sidebar-margin-top} - 52px); // 52px corresponds to "search" input size.
-            }
-        }
-        .reportbuilder-sidebar-settings {
-            position: fixed;
-            right: 30px;
-            max-height: calc(100vh - #{$sidebar-margin-top});
-        }
-        .reportbuilder-report[data-editing] .reportbuilder-report-container {
-            max-height: calc(100vh - #{$sidebar-margin-top});
-            overflow-y: auto;
-            @include thin-scrolls($gray-100);
-            margin-left: calc(#{$rb-left-sidebar-width} + 1rem);
-            margin-right: calc(#{$rb-right-sidebar-width} + 1rem);
-        }
-        .reportbuilder-audiences-container {
-            margin-left: calc(#{$rb-left-sidebar-width} + 1rem);
-        }
-    }
-}
-// Fix popper.js behaviour in fullpage report (using 'popup' page layout).
-#page-admin-reportbuilder-edit #page {
-    overflow-y: auto;
-}
+// Toggle cards
 
-/* Toggle cards. */
 .reportbuilder-toggle-card {
     .card-header {
         border-bottom: none;
@@ -282,9 +300,10 @@ $rb-right-sidebar-width: 350px;
     }
 }
 
-/* Audiences. */
+// Audiences tab
+
 .reportbuilder-audiences-container {
-    /* 'OR' separator. */
+    // 'OR' separator.
     .audience-separator {
         text-transform: uppercase;
         &::before,
@@ -300,7 +319,7 @@ $rb-right-sidebar-width: 350px;
             margin-left: 1rem;
         }
     }
-    /* Card action icons. */
+    // Card action icons.
     .instance-card {
         .card-header {
             i.icon {
@@ -310,7 +329,12 @@ $rb-right-sidebar-width: 350px;
     }
 }
 
-/* Report table card view styles */
+//
+// Card view.
+//
+
+// Mixin to covert a report table in a card
+
 @mixin table-cards {
     table.reportbuilder-table {
         thead {
@@ -375,6 +399,9 @@ $rb-right-sidebar-width: 350px;
         }
     }
 }
+
+// Logic to apply card-view mixin when necessary
+
 .reportbuilder-report[data-report-type="0"]:not([data-editing]) {
     // Report card view for small screens (if not forcing table).
     @include media-breakpoint-down(xs) {
diff --git a/theme/boost/style/moodle.css b/theme/boost/style/moodle.css
index a7dbfe5d0bdf9..07d83f0dd57b4 100644
--- a/theme/boost/style/moodle.css
+++ b/theme/boost/style/moodle.css
@@ -37763,14 +37763,19 @@ div.editor_atto_toolbar button .icon {
 }
 
 /**
-* Reportbuilder.
+* Reportbuilder styles.
 */
-/* Table */
+.reportbuilder-wrapper .btn-outline-secondary[data-toggle=collapse]:not(.collapsed),
+.reportbuilder-wrapper .dropdown.show .btn-outline-secondary[data-toggle=dropdown] {
+  color: #fff;
+  background-color: #6a737b;
+  border-color: #6a737b;
+}
+
 .reportbuilder-table .action-menu .menubar {
   justify-content: end;
 }
 
-/* Filters */
 .reportbuilder-wrapper .filters-dropdown {
   width: 27rem;
   padding: 0;
@@ -37782,68 +37787,127 @@ div.editor_atto_toolbar button .icon {
     width: 100%;
   }
 }
-.reportbuilder-wrapper .filters-dropdown .reportbuilder-filters-sidebar {
+
+.reportbuilder-filters-sidebar {
   max-height: calc(100vh - 60px - 1rem);
   overflow-y: auto;
   scrollbar-width: thin;
   scrollbar-color: #6a737b #fff;
 }
-.reportbuilder-wrapper .filters-dropdown .reportbuilder-filters-sidebar::-webkit-scrollbar {
+.reportbuilder-filters-sidebar::-webkit-scrollbar {
   width: 12px;
 }
-.reportbuilder-wrapper .filters-dropdown .reportbuilder-filters-sidebar::-webkit-scrollbar-track {
+.reportbuilder-filters-sidebar::-webkit-scrollbar-track {
   background: #fff;
 }
-.reportbuilder-wrapper .filters-dropdown .reportbuilder-filters-sidebar::-webkit-scrollbar-thumb {
+.reportbuilder-filters-sidebar::-webkit-scrollbar-thumb {
   background-color: #6a737b;
   border-radius: 20px;
   border: 3px solid #fff;
 }
-.reportbuilder-wrapper .filters-dropdown .reportbuilder-filters-sidebar::-webkit-scrollbar-thumb:hover {
+.reportbuilder-filters-sidebar::-webkit-scrollbar-thumb:hover {
   background-color: #495057;
 }
-.reportbuilder-wrapper .reportbuilder-filters-wrapper .mform.full-width-labels .fitem.row > .col-md-3,
-.reportbuilder-wrapper .reportbuilder-filters-wrapper .mform.full-width-labels .fitem.row > .col-md-9,
-.reportbuilder-wrapper .reportbuilder-conditions-list .mform.full-width-labels .fitem.row > .col-md-3,
-.reportbuilder-wrapper .reportbuilder-conditions-list .mform.full-width-labels .fitem.row > .col-md-9 {
-  flex: 0 0 100%;
-  max-width: 100%;
-}
-.reportbuilder-wrapper .reportbuilder-filters-wrapper .mform.full-width-labels .fitem.row .fdate_selector,
-.reportbuilder-wrapper .reportbuilder-conditions-list .mform.full-width-labels .fitem.row .fdate_selector {
-  flex-wrap: wrap;
-}
-.reportbuilder-wrapper .reportbuilder-filters-wrapper .mform .form-group,
-.reportbuilder-wrapper .reportbuilder-conditions-list .mform .form-group {
-  margin-bottom: 0;
-  max-width: 100%;
-}
-.reportbuilder-wrapper .reportbuilder-filters-wrapper .mform .form-group > span,
-.reportbuilder-wrapper .reportbuilder-conditions-list .mform .form-group > span {
-  max-width: 100%;
-}
-.reportbuilder-wrapper .reportbuilder-filters-wrapper .filter .filter-header,
-.reportbuilder-wrapper .reportbuilder-conditions-list .filter .filter-header {
+.reportbuilder-filters-sidebar .filter .filter-header {
   font-size: 1.171875rem;
 }
-.reportbuilder-wrapper .reportbuilder-filters-wrapper .filter .filter-header .filter-name,
-.reportbuilder-wrapper .reportbuilder-conditions-list .filter .filter-header .filter-name {
-  font-size: 1rem;
+.reportbuilder-filters-sidebar .filter .filter-header .filter-name {
+  font-size: 0.9375rem;
   white-space: nowrap;
   overflow: hidden;
   text-overflow: ellipsis;
   padding-right: 1rem;
 }
-.reportbuilder-wrapper .reportbuilder-filters-wrapper .filter .filter-header .filter-name:hover,
-.reportbuilder-wrapper .reportbuilder-conditions-list .filter .filter-header .filter-name:hover {
+.reportbuilder-filters-sidebar .filter .filter-header .filter-name:hover {
   white-space: normal;
   text-overflow: clip;
   word-break: break-all;
 }
 
-/**
-* Custom Reports.
-*/
+.reportbuilder-filters-wrapper .mform.full-width-labels .fdate_selector,
+.reportbuilder-conditions-list .mform.full-width-labels .fdate_selector {
+  flex-wrap: wrap;
+}
+.reportbuilder-filters-wrapper .mform.full-width-labels .form-group,
+.reportbuilder-conditions-list .mform.full-width-labels .form-group {
+  margin-bottom: 0;
+  max-width: 100%;
+}
+.reportbuilder-filters-wrapper .mform.full-width-labels .form-group:not(.row):last-child,
+.reportbuilder-conditions-list .mform.full-width-labels .form-group:not(.row):last-child {
+  flex: 1;
+  min-width: 0;
+}
+.reportbuilder-filters-wrapper .mform.full-width-labels .form-group:not(.row):last-child span,
+.reportbuilder-filters-wrapper .mform.full-width-labels .form-group:not(.row):last-child .custom-select,
+.reportbuilder-conditions-list .mform.full-width-labels .form-group:not(.row):last-child span,
+.reportbuilder-conditions-list .mform.full-width-labels .form-group:not(.row):last-child .custom-select {
+  width: 100%;
+}
+
+@media (min-width: 992px) {
+  .path-admin-reportbuilder.pagelayout-popup.behat-site .fixed-top {
+    position: fixed;
+  }
+  .path-admin-reportbuilder.pagelayout-popup #region-main {
+    border: none;
+    padding: 0;
+  }
+  .path-admin-reportbuilder.pagelayout-popup #maincontent {
+    visibility: hidden;
+  }
+  .path-admin-reportbuilder.pagelayout-popup .dynamictabs .nav-tabs {
+    position: fixed;
+    z-index: 1030;
+    width: calc(100% - 35px);
+    padding-top: 1.25rem;
+    background-color: #fff;
+    box-shadow: 0 1.25rem 0 #fff;
+  }
+  .path-admin-reportbuilder.pagelayout-popup .dynamictabs .tab-content {
+    padding-top: 83px;
+  }
+  .path-admin-reportbuilder.pagelayout-popup .reportbuilder-sidebar-menu {
+    position: fixed;
+  }
+  .path-admin-reportbuilder.pagelayout-popup .reportbuilder-sidebar-menu .reportbuilder-sidebar-menu-cards {
+    max-height: calc(100vh - 163px - 52px);
+  }
+  .path-admin-reportbuilder.pagelayout-popup .reportbuilder-sidebar-settings {
+    position: fixed;
+    right: 30px;
+    max-height: calc(100vh - 163px);
+  }
+  .path-admin-reportbuilder.pagelayout-popup .reportbuilder-report[data-editing] .reportbuilder-report-container {
+    max-height: calc(100vh - 163px);
+    overflow-y: auto;
+    scrollbar-width: thin;
+    scrollbar-color: #6a737b #f8f9fa;
+    margin-left: calc(250px + 1rem);
+    margin-right: calc(350px + 1rem);
+  }
+  .path-admin-reportbuilder.pagelayout-popup .reportbuilder-report[data-editing] .reportbuilder-report-container::-webkit-scrollbar {
+    width: 12px;
+  }
+  .path-admin-reportbuilder.pagelayout-popup .reportbuilder-report[data-editing] .reportbuilder-report-container::-webkit-scrollbar-track {
+    background: #f8f9fa;
+  }
+  .path-admin-reportbuilder.pagelayout-popup .reportbuilder-report[data-editing] .reportbuilder-report-container::-webkit-scrollbar-thumb {
+    background-color: #6a737b;
+    border-radius: 20px;
+    border: 3px solid #f8f9fa;
+  }
+  .path-admin-reportbuilder.pagelayout-popup .reportbuilder-report[data-editing] .reportbuilder-report-container::-webkit-scrollbar-thumb:hover {
+    background-color: #495057;
+  }
+  .path-admin-reportbuilder.pagelayout-popup .reportbuilder-audiences-container {
+    margin-left: calc(250px + 1rem);
+  }
+}
+#page-admin-reportbuilder-edit #page {
+  overflow-y: auto;
+}
+
 .reportbuilder-report-container {
   min-width: 0;
 }
@@ -37855,7 +37919,6 @@ div.editor_atto_toolbar button .icon {
   overflow-x: auto;
 }
 
-/* Custom table headers */
 .reportbuilder-table th button[data-action=report-remove-column] .icon,
 .reportbuilder-table th span[data-drag-type=move] .icon {
   width: 12px;
@@ -37868,7 +37931,6 @@ div.editor_atto_toolbar button .icon {
   margin-right: 0;
 }
 
-/* Sidebar menu */
 @media (min-width: 992px) {
   .reportbuilder-sidebar-menu {
     width: 250px;
@@ -37904,7 +37966,6 @@ div.editor_atto_toolbar button .icon {
   background-color: #495057;
 }
 
-/* Settings sidebar */
 .reportbuilder-sidebar-settings {
   overflow-y: auto;
   scrollbar-width: thin;
@@ -37962,15 +38023,6 @@ div.editor_atto_toolbar button .icon {
   width: 100%;
 }
 
-/* Add button styles when a toggle button is active. */
-.reportbuilder-wrapper button.btn-outline-secondary[data-toggle=collapse]:not(.collapsed),
-.reportbuilder-wrapper .dropdown.show button.btn-outline-secondary[data-toggle=dropdown] {
-  color: #fff;
-  background-color: #6a737b;
-  border-color: #6a737b;
-}
-
-/* Drag&drop styles. */
 .reportbuilder-sortable-list li.sortable-list-current-position,
 .reportbuilder-table th.sortable-list-current-position,
 .reportbuilder-conditions-list .condition.sortable-list-current-position {
@@ -37983,71 +38035,6 @@ div.editor_atto_toolbar button .icon {
   opacity: 0.85;
 }
 
-/* Reportbuilder full page styles. */
-@media (min-width: 992px) {
-  .path-admin-reportbuilder.pagelayout-popup.behat-site .fixed-top {
-    position: fixed;
-  }
-  .path-admin-reportbuilder.pagelayout-popup #region-main {
-    border: none;
-    padding: 0;
-  }
-  .path-admin-reportbuilder.pagelayout-popup #maincontent {
-    visibility: hidden;
-  }
-  .path-admin-reportbuilder.pagelayout-popup .dynamictabs .nav-tabs {
-    position: fixed;
-    z-index: 1030;
-    width: calc(100% - 35px);
-    padding-top: 1.25rem;
-    background-color: #fff;
-    box-shadow: 0 1.25rem 0 #fff;
-  }
-  .path-admin-reportbuilder.pagelayout-popup .dynamictabs .tab-content {
-    padding-top: 83px;
-  }
-  .path-admin-reportbuilder.pagelayout-popup .reportbuilder-sidebar-menu {
-    position: fixed;
-  }
-  .path-admin-reportbuilder.pagelayout-popup .reportbuilder-sidebar-menu .reportbuilder-sidebar-menu-cards {
-    max-height: calc(100vh - 163px - 52px);
-  }
-  .path-admin-reportbuilder.pagelayout-popup .reportbuilder-sidebar-settings {
-    position: fixed;
-    right: 30px;
-    max-height: calc(100vh - 163px);
-  }
-  .path-admin-reportbuilder.pagelayout-popup .reportbuilder-report[data-editing] .reportbuilder-report-container {
-    max-height: calc(100vh - 163px);
-    overflow-y: auto;
-    scrollbar-width: thin;
-    scrollbar-color: #6a737b #f8f9fa;
-    margin-left: calc(250px + 1rem);
-    margin-right: calc(350px + 1rem);
-  }
-  .path-admin-reportbuilder.pagelayout-popup .reportbuilder-report[data-editing] .reportbuilder-report-container::-webkit-scrollbar {
-    width: 12px;
-  }
-  .path-admin-reportbuilder.pagelayout-popup .reportbuilder-report[data-editing] .reportbuilder-report-container::-webkit-scrollbar-track {
-    background: #f8f9fa;
-  }
-  .path-admin-reportbuilder.pagelayout-popup .reportbuilder-report[data-editing] .reportbuilder-report-container::-webkit-scrollbar-thumb {
-    background-color: #6a737b;
-    border-radius: 20px;
-    border: 3px solid #f8f9fa;
-  }
-  .path-admin-reportbuilder.pagelayout-popup .reportbuilder-report[data-editing] .reportbuilder-report-container::-webkit-scrollbar-thumb:hover {
-    background-color: #495057;
-  }
-  .path-admin-reportbuilder.pagelayout-popup .reportbuilder-audiences-container {
-    margin-left: calc(250px + 1rem);
-  }
-}
-#page-admin-reportbuilder-edit #page {
-  overflow-y: auto;
-}
-
-/* Toggle cards. */
 .reportbuilder-toggle-card .card-header {
   border-bottom: none;
 }
@@ -38072,11 +38059,6 @@ div.editor_atto_toolbar button .icon {
   display: none;
 }
 
-/* Audiences. */
-.reportbuilder-audiences-container {
-  /* 'OR' separator. */
-  /* Card action icons. */
-}
 .reportbuilder-audiences-container .audience-separator {
   text-transform: uppercase;
 }
@@ -38095,7 +38077,6 @@ div.editor_atto_toolbar button .icon {
   margin-right: 0;
 }
 
-/* Report table card view styles */
 @media (max-width: 575.98px) {
   .reportbuilder-report[data-report-type="0"]:not([data-editing]):not([data-force-table]) table.reportbuilder-table thead {
     display: none;
diff --git a/theme/classic/style/moodle.css b/theme/classic/style/moodle.css
index 86e5106fa3c52..d149695ea26fa 100644
--- a/theme/classic/style/moodle.css
+++ b/theme/classic/style/moodle.css
@@ -37697,14 +37697,19 @@ div.editor_atto_toolbar button .icon {
 }
 
 /**
-* Reportbuilder.
+* Reportbuilder styles.
 */
-/* Table */
+.reportbuilder-wrapper .btn-outline-secondary[data-toggle=collapse]:not(.collapsed),
+.reportbuilder-wrapper .dropdown.show .btn-outline-secondary[data-toggle=dropdown] {
+  color: #fff;
+  background-color: #6a737b;
+  border-color: #6a737b;
+}
+
 .reportbuilder-table .action-menu .menubar {
   justify-content: end;
 }
 
-/* Filters */
 .reportbuilder-wrapper .filters-dropdown {
   width: 27rem;
   padding: 0;
@@ -37716,68 +37721,127 @@ div.editor_atto_toolbar button .icon {
     width: 100%;
   }
 }
-.reportbuilder-wrapper .filters-dropdown .reportbuilder-filters-sidebar {
+
+.reportbuilder-filters-sidebar {
   max-height: calc(100vh - 50px - 1rem);
   overflow-y: auto;
   scrollbar-width: thin;
   scrollbar-color: #6a737b #fff;
 }
-.reportbuilder-wrapper .filters-dropdown .reportbuilder-filters-sidebar::-webkit-scrollbar {
+.reportbuilder-filters-sidebar::-webkit-scrollbar {
   width: 12px;
 }
-.reportbuilder-wrapper .filters-dropdown .reportbuilder-filters-sidebar::-webkit-scrollbar-track {
+.reportbuilder-filters-sidebar::-webkit-scrollbar-track {
   background: #fff;
 }
-.reportbuilder-wrapper .filters-dropdown .reportbuilder-filters-sidebar::-webkit-scrollbar-thumb {
+.reportbuilder-filters-sidebar::-webkit-scrollbar-thumb {
   background-color: #6a737b;
   border-radius: 20px;
   border: 3px solid #fff;
 }
-.reportbuilder-wrapper .filters-dropdown .reportbuilder-filters-sidebar::-webkit-scrollbar-thumb:hover {
+.reportbuilder-filters-sidebar::-webkit-scrollbar-thumb:hover {
   background-color: #495057;
 }
-.reportbuilder-wrapper .reportbuilder-filters-wrapper .mform.full-width-labels .fitem.row > .col-md-3,
-.reportbuilder-wrapper .reportbuilder-filters-wrapper .mform.full-width-labels .fitem.row > .col-md-9,
-.reportbuilder-wrapper .reportbuilder-conditions-list .mform.full-width-labels .fitem.row > .col-md-3,
-.reportbuilder-wrapper .reportbuilder-conditions-list .mform.full-width-labels .fitem.row > .col-md-9 {
-  flex: 0 0 100%;
-  max-width: 100%;
-}
-.reportbuilder-wrapper .reportbuilder-filters-wrapper .mform.full-width-labels .fitem.row .fdate_selector,
-.reportbuilder-wrapper .reportbuilder-conditions-list .mform.full-width-labels .fitem.row .fdate_selector {
-  flex-wrap: wrap;
-}
-.reportbuilder-wrapper .reportbuilder-filters-wrapper .mform .form-group,
-.reportbuilder-wrapper .reportbuilder-conditions-list .mform .form-group {
-  margin-bottom: 0;
-  max-width: 100%;
-}
-.reportbuilder-wrapper .reportbuilder-filters-wrapper .mform .form-group > span,
-.reportbuilder-wrapper .reportbuilder-conditions-list .mform .form-group > span {
-  max-width: 100%;
-}
-.reportbuilder-wrapper .reportbuilder-filters-wrapper .filter .filter-header,
-.reportbuilder-wrapper .reportbuilder-conditions-list .filter .filter-header {
+.reportbuilder-filters-sidebar .filter .filter-header {
   font-size: 1.171875rem;
 }
-.reportbuilder-wrapper .reportbuilder-filters-wrapper .filter .filter-header .filter-name,
-.reportbuilder-wrapper .reportbuilder-conditions-list .filter .filter-header .filter-name {
-  font-size: 1rem;
+.reportbuilder-filters-sidebar .filter .filter-header .filter-name {
+  font-size: 0.9375rem;
   white-space: nowrap;
   overflow: hidden;
   text-overflow: ellipsis;
   padding-right: 1rem;
 }
-.reportbuilder-wrapper .reportbuilder-filters-wrapper .filter .filter-header .filter-name:hover,
-.reportbuilder-wrapper .reportbuilder-conditions-list .filter .filter-header .filter-name:hover {
+.reportbuilder-filters-sidebar .filter .filter-header .filter-name:hover {
   white-space: normal;
   text-overflow: clip;
   word-break: break-all;
 }
 
-/**
-* Custom Reports.
-*/
+.reportbuilder-filters-wrapper .mform.full-width-labels .fdate_selector,
+.reportbuilder-conditions-list .mform.full-width-labels .fdate_selector {
+  flex-wrap: wrap;
+}
+.reportbuilder-filters-wrapper .mform.full-width-labels .form-group,
+.reportbuilder-conditions-list .mform.full-width-labels .form-group {
+  margin-bottom: 0;
+  max-width: 100%;
+}
+.reportbuilder-filters-wrapper .mform.full-width-labels .form-group:not(.row):last-child,
+.reportbuilder-conditions-list .mform.full-width-labels .form-group:not(.row):last-child {
+  flex: 1;
+  min-width: 0;
+}
+.reportbuilder-filters-wrapper .mform.full-width-labels .form-group:not(.row):last-child span,
+.reportbuilder-filters-wrapper .mform.full-width-labels .form-group:not(.row):last-child .custom-select,
+.reportbuilder-conditions-list .mform.full-width-labels .form-group:not(.row):last-child span,
+.reportbuilder-conditions-list .mform.full-width-labels .form-group:not(.row):last-child .custom-select {
+  width: 100%;
+}
+
+@media (min-width: 992px) {
+  .path-admin-reportbuilder.pagelayout-popup.behat-site .fixed-top {
+    position: fixed;
+  }
+  .path-admin-reportbuilder.pagelayout-popup #region-main {
+    border: none;
+    padding: 0;
+  }
+  .path-admin-reportbuilder.pagelayout-popup #maincontent {
+    visibility: hidden;
+  }
+  .path-admin-reportbuilder.pagelayout-popup .dynamictabs .nav-tabs {
+    position: fixed;
+    z-index: 1030;
+    width: calc(100% - 35px);
+    padding-top: 1.25rem;
+    background-color: #fff;
+    box-shadow: 0 1.25rem 0 #fff;
+  }
+  .path-admin-reportbuilder.pagelayout-popup .dynamictabs .tab-content {
+    padding-top: 83px;
+  }
+  .path-admin-reportbuilder.pagelayout-popup .reportbuilder-sidebar-menu {
+    position: fixed;
+  }
+  .path-admin-reportbuilder.pagelayout-popup .reportbuilder-sidebar-menu .reportbuilder-sidebar-menu-cards {
+    max-height: calc(100vh - 153px - 52px);
+  }
+  .path-admin-reportbuilder.pagelayout-popup .reportbuilder-sidebar-settings {
+    position: fixed;
+    right: 30px;
+    max-height: calc(100vh - 153px);
+  }
+  .path-admin-reportbuilder.pagelayout-popup .reportbuilder-report[data-editing] .reportbuilder-report-container {
+    max-height: calc(100vh - 153px);
+    overflow-y: auto;
+    scrollbar-width: thin;
+    scrollbar-color: #6a737b #f8f9fa;
+    margin-left: calc(250px + 1rem);
+    margin-right: calc(350px + 1rem);
+  }
+  .path-admin-reportbuilder.pagelayout-popup .reportbuilder-report[data-editing] .reportbuilder-report-container::-webkit-scrollbar {
+    width: 12px;
+  }
+  .path-admin-reportbuilder.pagelayout-popup .reportbuilder-report[data-editing] .reportbuilder-report-container::-webkit-scrollbar-track {
+    background: #f8f9fa;
+  }
+  .path-admin-reportbuilder.pagelayout-popup .reportbuilder-report[data-editing] .reportbuilder-report-container::-webkit-scrollbar-thumb {
+    background-color: #6a737b;
+    border-radius: 20px;
+    border: 3px solid #f8f9fa;
+  }
+  .path-admin-reportbuilder.pagelayout-popup .reportbuilder-report[data-editing] .reportbuilder-report-container::-webkit-scrollbar-thumb:hover {
+    background-color: #495057;
+  }
+  .path-admin-reportbuilder.pagelayout-popup .reportbuilder-audiences-container {
+    margin-left: calc(250px + 1rem);
+  }
+}
+#page-admin-reportbuilder-edit #page {
+  overflow-y: auto;
+}
+
 .reportbuilder-report-container {
   min-width: 0;
 }
@@ -37789,7 +37853,6 @@ div.editor_atto_toolbar button .icon {
   overflow-x: auto;
 }
 
-/* Custom table headers */
 .reportbuilder-table th button[data-action=report-remove-column] .icon,
 .reportbuilder-table th span[data-drag-type=move] .icon {
   width: 12px;
@@ -37802,7 +37865,6 @@ div.editor_atto_toolbar button .icon {
   margin-right: 0;
 }
 
-/* Sidebar menu */
 @media (min-width: 992px) {
   .reportbuilder-sidebar-menu {
     width: 250px;
@@ -37838,7 +37900,6 @@ div.editor_atto_toolbar button .icon {
   background-color: #495057;
 }
 
-/* Settings sidebar */
 .reportbuilder-sidebar-settings {
   overflow-y: auto;
   scrollbar-width: thin;
@@ -37896,15 +37957,6 @@ div.editor_atto_toolbar button .icon {
   width: 100%;
 }
 
-/* Add button styles when a toggle button is active. */
-.reportbuilder-wrapper button.btn-outline-secondary[data-toggle=collapse]:not(.collapsed),
-.reportbuilder-wrapper .dropdown.show button.btn-outline-secondary[data-toggle=dropdown] {
-  color: #fff;
-  background-color: #6a737b;
-  border-color: #6a737b;
-}
-
-/* Drag&drop styles. */
 .reportbuilder-sortable-list li.sortable-list-current-position,
 .reportbuilder-table th.sortable-list-current-position,
 .reportbuilder-conditions-list .condition.sortable-list-current-position {
@@ -37917,71 +37969,6 @@ div.editor_atto_toolbar button .icon {
   opacity: 0.85;
 }
 
-/* Reportbuilder full page styles. */
-@media (min-width: 992px) {
-  .path-admin-reportbuilder.pagelayout-popup.behat-site .fixed-top {
-    position: fixed;
-  }
-  .path-admin-reportbuilder.pagelayout-popup #region-main {
-    border: none;
-    padding: 0;
-  }
-  .path-admin-reportbuilder.pagelayout-popup #maincontent {
-    visibility: hidden;
-  }
-  .path-admin-reportbuilder.pagelayout-popup .dynamictabs .nav-tabs {
-    position: fixed;
-    z-index: 1030;
-    width: calc(100% - 35px);
-    padding-top: 1.25rem;
-    background-color: #fff;
-    box-shadow: 0 1.25rem 0 #fff;
-  }
-  .path-admin-reportbuilder.pagelayout-popup .dynamictabs .tab-content {
-    padding-top: 83px;
-  }
-  .path-admin-reportbuilder.pagelayout-popup .reportbuilder-sidebar-menu {
-    position: fixed;
-  }
-  .path-admin-reportbuilder.pagelayout-popup .reportbuilder-sidebar-menu .reportbuilder-sidebar-menu-cards {
-    max-height: calc(100vh - 153px - 52px);
-  }
-  .path-admin-reportbuilder.pagelayout-popup .reportbuilder-sidebar-settings {
-    position: fixed;
-    right: 30px;
-    max-height: calc(100vh - 153px);
-  }
-  .path-admin-reportbuilder.pagelayout-popup .reportbuilder-report[data-editing] .reportbuilder-report-container {
-    max-height: calc(100vh - 153px);
-    overflow-y: auto;
-    scrollbar-width: thin;
-    scrollbar-color: #6a737b #f8f9fa;
-    margin-left: calc(250px + 1rem);
-    margin-right: calc(350px + 1rem);
-  }
-  .path-admin-reportbuilder.pagelayout-popup .reportbuilder-report[data-editing] .reportbuilder-report-container::-webkit-scrollbar {
-    width: 12px;
-  }
-  .path-admin-reportbuilder.pagelayout-popup .reportbuilder-report[data-editing] .reportbuilder-report-container::-webkit-scrollbar-track {
-    background: #f8f9fa;
-  }
-  .path-admin-reportbuilder.pagelayout-popup .reportbuilder-report[data-editing] .reportbuilder-report-container::-webkit-scrollbar-thumb {
-    background-color: #6a737b;
-    border-radius: 20px;
-    border: 3px solid #f8f9fa;
-  }
-  .path-admin-reportbuilder.pagelayout-popup .reportbuilder-report[data-editing] .reportbuilder-report-container::-webkit-scrollbar-thumb:hover {
-    background-color: #495057;
-  }
-  .path-admin-reportbuilder.pagelayout-popup .reportbuilder-audiences-container {
-    margin-left: calc(250px + 1rem);
-  }
-}
-#page-admin-reportbuilder-edit #page {
-  overflow-y: auto;
-}
-
-/* Toggle cards. */
 .reportbuilder-toggle-card .card-header {
   border-bottom: none;
 }
@@ -38006,11 +37993,6 @@ div.editor_atto_toolbar button .icon {
   display: none;
 }
 
-/* Audiences. */
-.reportbuilder-audiences-container {
-  /* 'OR' separator. */
-  /* Card action icons. */
-}
 .reportbuilder-audiences-container .audience-separator {
   text-transform: uppercase;
 }
@@ -38029,7 +38011,6 @@ div.editor_atto_toolbar button .icon {
   margin-right: 0;
 }
 
-/* Report table card view styles */
 @media (max-width: 575.98px) {
   .reportbuilder-report[data-report-type="0"]:not([data-editing]):not([data-force-table]) table.reportbuilder-table thead {
     display: none;