Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Score ranking bug #2479

Open
sergiozeppo opened this issue May 22, 2024 · 2 comments
Open

Score ranking bug #2479

sergiozeppo opened this issue May 22, 2024 · 2 comments

Comments

@sergiozeppo
Copy link

Describe the bug
There comes a point in every RSS course when students are expelled or they do it on their own. In this case, further study of the remaining students is associated with a bug that does not allow them to know the current position in the ranking.

It leads to consequences like this
image

A student will not be able to accurately determine his/her position even if he/she moves to Score. A student will only be able to understand it roughly relative to others whose positions in the ranking are more or less similar to the truth.

Here is the last page rankings, with only 526 students remaining at the time of writing this issue. As you can see, none of them have the correct position.
image

This is because the student position number is taken from the overall table and the number of active students is recalculated separately.

To Reproduce
Steps to reproduce the behavior:

  1. Go to the JavaScript/Front-end 2023Q4 course, mentioned in this issue
  2. Go to Score
  3. Review that Active Students Only checkbox is ON by default
  4. Go to the last page
  5. Remember the number of students near the navigation panel
  6. Choose the random student to ensure his/her position isn't right
  7. Turn off Active Students Only checkbox
  8. Review that the number of students near the navigation panel increased
  9. Find chosen random student via github/name/etc.
  10. Notify that number of his/her position is not changed
  11. See the bug.

Expected behavior
The bug can be fixed (as I think) by recalculating the position numbers relative to condition of Active Students Only checkbox, and respectively to the number of active/inactive students

Device (please complete the following information):
This bug is not depend on the device or operating system.

Additional context
This bug doesn't just affect students from the last page. Since the mass expulsions, the bug affects students starting from the middle of the table.

@AlreadyBored AlreadyBored self-assigned this Jun 23, 2024
@AlreadyBored
Copy link
Contributor

@sergiozeppo this is not a bug, we simply calculate score over all students, not only active, nobody told that position in total score should depend on "Active students only" toggle. However, we will review existing approach and decide whether there's a space for improvement, thank you for your intake anyway :)

@sergiozeppo
Copy link
Author

this is not a bug, we simply calculate score over all students, not only active, nobody told that position in total score should depend on "Active students only" toggle.

Thanks for the answer.
I didn't spelled it correctrly, of course, it's not a bug.
But this is a quite confusing and illogical thing, I guess. And it starts to confuse students right in the dashboard.
If you find the time, consider implementing this feature.
Thanks in advance!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants