Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FSD: Widget Merch #551

Open
Quiddlee opened this issue Sep 25, 2024 · 0 comments
Open

FSD: Widget Merch #551

Quiddlee opened this issue Sep 25, 2024 · 0 comments
Assignees
@MielomankA
Labels
high priority refactor
Milestone
🛸 Migration to Fe...

Comments

@Quiddlee
Copy link
Member

📝 Describe the refactoring task

Part of the issue #347

📍 Code location

src/widgets/merch

✅ Definition of Done (DoD):

  1. Refactor merch.tsx's scss as following
  • remove all parent selector & .card-content -> .card-content.
  • change all possible values to variables if such exists.
  • and everything in your opinion that needs to be refactored
  • replace all element selectors by tag with class selector img -> .image

merch.tsx

  1. move merch.test.tsx to ui folder
  2. replace div's with HTML5 tags
  3. rename image constant to something more meaningful
  4. add descriptive alt attribute

merch.test.tsx

  1. replace Discover merch assets hardcoded link with constant
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@MielomankA MielomankA

Labels
high priority refactor
Projects
RS Site
Status: Todo
Milestone
🛸 Migration to Feature Sliced Design ...
Development

No branches or pull requests
2 participants
@MielomankA @Quiddlee