Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build(ci): merge validation in a unique workflow (2/2) #1577

Closed
wants to merge 7 commits into from

Conversation

jerome-benoit
Copy link

@jerome-benoit jerome-benoit commented Sep 5, 2023

Improve repo CI

This PR contains:

  • bugfix
  • feature
  • refactor
  • documentation
  • other

Are tests included?

  • yes (bugfixes and features will not be merged without tests)
  • no

Breaking Changes?

  • yes (breaking changes will not be merged unless absolutely necessary)
  • no

Description

That PR is a followup of #1576.

Changes:

  • Merge validation in a unique workflow by using an os matrix
  • Run relevant steps only once, such as code linting/formatting check

Jérôme Benoit added 7 commits September 5, 2023 19:27
- pnpm v8 has dropped support for node 14, remove it
- add node 20 to node versions matrix
- bump GH actions version to latest

Signed-off-by: Jérôme Benoit <[email protected]>
Signed-off-by: Jérôme Benoit <[email protected]>
Signed-off-by: Jérôme Benoit <[email protected]>
@jerome-benoit jerome-benoit changed the title build(ci): merge validation in a unique workflow build(ci): merge validation in a unique workflow (2/2) Sep 5, 2023
@shellscape
Copy link
Collaborator

shellscape commented Sep 5, 2023

Sorry, this is not a change I'm interested in at the moment.

@shellscape shellscape closed this Sep 5, 2023
@jerome-benoit
Copy link
Author

jerome-benoit commented Sep 5, 2023

You can just flag it as 'postponed' or 'notimportant' or similar instead of closing without detailed explanations a PR:

  • reducing the CI workflow code surface to maintain
  • speeding up the CI a bit
  • ensuring the PR validation coverage is the same for all OS

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants